docs(eloquent): fix stale @method annotations after __callStatic fix#63
Merged
benkhalife merged 1 commit intoJun 30, 2026
Merged
Conversation
The IDE-helper @method block on Model still typed chainable methods (select, where, orderBy, join, groupBy, limit/offset, dump) as returning Foxdb\Query\Builder — accurate before the __callStatic fix, but stale afterwards, since static::query()->$name(...) now returns ModelBuilder. This caused IDEs to flag with() as unknown when chained after select(), even though it works correctly at runtime. Updates all chainable-method annotations to ModelBuilder and adds an explicit @method for with() returning EagerBuilder. Terminal methods (get, count, paginate, insert, ...) were already correctly typed and are unchanged. Docblock-only change — no runtime behaviour affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IDE-helper @method block on Model still typed chainable methods (select, where, orderBy, join, groupBy, limit/offset, dump) as returning Foxdb\Query\Builder — accurate before the __callStatic fix, but stale afterwards, since static::query()->$name(...) now returns ModelBuilder. This caused IDEs to flag with() as unknown when chained after select(), even though it works correctly at runtime.
Updates all chainable-method annotations to ModelBuilder and adds an explicit @method for with() returning EagerBuilder. Terminal methods (get, count, paginate, insert, ...) were already correctly typed and are unchanged. Docblock-only change — no runtime behaviour affected.