Fix/paginate ignores with eager load#62
Merged
Merged
Conversation
EagerBuilder only declared get() and first() as terminal methods that
trigger Model::eagerLoad(). paginate() fell through __call() straight
to the underlying Query\Builder::paginate(), which runs its own get()
internally and never touches eager loading — silently dropping any
with() chained before it.
Practical effect: Model::with('relation')->paginate(...) returned a
page whose rows had the relation unloaded. Accessing it afterwards
fell back to lazy loading per row, reproducing full N+1 (e.g. 12
queries for a 10-row page instead of 3) with no error to signal it.
Adds EagerBuilder::paginate(), which runs the page query then calls
Model::eagerLoad() on $page->data before returning — mirroring what
get() and first() already do.
Adds coverage for Model::with(...)->paginate(...) and the select()->with()->paginate() chain, asserting the relation is marked loaded on each row of the page. Also adds a query-count test proving paginate() + with() now uses a constant 3 queries (count + page select + one whereIn for the relation) on a 10-row page, instead of 3 + N from the silent fallback to lazy loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.