styles: add dark variant for placeholder#8160
Merged
alexander-akait merged 3 commits intowebpack:mainfrom Apr 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
please rebase |
TusharThakur04
force-pushed
the
styles/placeholder-dark-scss
branch
from
bb5f6b3 to
77d3398
Compare
| background: linear-gradient(90deg, #252525, #121212, #252525); | ||
| } | ||
| } | ||
| } */ |
Member
There was a problem hiding this comment.
Just remove it if we don't need it
alexander-akait
approved these changes
Apr 3, 2026
Member
|
@TusharThakur04 feel free to reduce classes in css more where we can use tailwind utils |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports: #8047
Summary
This PR refactors the placeholder component to handle dark mode using dark variant instead of SCSS.
What kind of change does this PR introduce?
styles
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
no
results are same :
