fix(SidebarMobile): move body event listeners to lifecycle methods#8155
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Apr 2, 2026
Merged
Conversation
Calling _toggleBodyListener inside render() causes side effects on every render cycle. React StrictMode double-invokes renders in dev, which leads to unpredictable listener state. Also, listeners were never cleaned up on unmount when isOpen was true, causing a leak. Move listener management to componentDidMount, componentDidUpdate (only when isOpen changes), and componentWillUnmount. Fixes webpack#8148
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexander-akait
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_toggleBodyListenerwas called insiderender(), which runs on every re-render, not just whenisOpenchanges. The listeners don't actually duplicate (_handleBodyClickis a stable class field reference, soaddEventListenerdeduplicates by reference), but side effects inrender()break React's purity contract. React StrictMode double-invokes renders in dev, so listener state becomes unpredictable. There was also no cleanup on unmount - if the sidebar was open when the component unmounted, thetouchstartandmousedownlisteners onwindowwould just stay there.Moved listener management to
componentDidMount,componentDidUpdate(only whenisOpenactually changes), andcomponentWillUnmount.Fixes #8148.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
No