Skip to content

refactor(Sponsors): migrate from SCSS to Tailwind CSS#8096

Merged
alexander-akait merged 7 commits intowebpack:mainfrom
mr-baraiya:refactor/sponsors-tailwind
Mar 26, 2026
Merged

refactor(Sponsors): migrate from SCSS to Tailwind CSS#8096
alexander-akait merged 7 commits intowebpack:mainfrom
mr-baraiya:refactor/sponsors-tailwind

Conversation

@mr-baraiya
Copy link
Copy Markdown
Contributor

Part of #8047

Changes

  • Migrated Sponsors component from SCSS to Tailwind CSS
  • Removed Sponsors.scss file
  • Replaced all styles with Tailwind utility classes
  • Preserved existing layout and visual behavior

Notes

  • No functional changes introduced
  • Continues incremental migration away from SCSS

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-js-org Ready Ready Preview, Comment Mar 26, 2026 2:27pm

Request Review

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

The failing checks seem unrelated to this PR.

The error originates from tailwind.css asset resolution:
"Can't resolve '../../assets/ag-charts-logo-dark.png'"

This PR only modifies the Sponsors component and does not touch global styles.

Please let me know if you'd like me to investigate or fix this separately.

@alexander-akait
Copy link
Copy Markdown
Member

@mr-baraiya please rebase

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Rebased on latest main and fixed the failing checks (asset path + lint issues).

@alexander-akait
Copy link
Copy Markdown
Member

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Improved hover behavior and fixed contrast issues.

@alexander-akait
Copy link
Copy Markdown
Member

When I click switch to dark theme it have very ugly white effect

@alexander-akait
Copy link
Copy Markdown
Member

Do you check your results - https://webpack-js-org-git-fork-mr-baraiya-refactor-spons-2fdf22-openjs.vercel.app/concepts/? It looks very bad, please use your own hands to fix it not only AI generated code

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Apologies — you’re right, I didn’t review it properly before.

I checked everything again and fixed the issues step by step:

  • font size in light mode
  • white flash during theme switch
  • AG Grid / AG Charts background and glow in dark mode

It should be much cleaner now. Please take another look.

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Hi, just a quick follow-up — I’ve updated the SplashViz styling as per feedback. Could you please take another look when you have time?

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase main

@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Done! I have rebased the branch onto the latest main.

@alexander-akait alexander-akait merged commit b5bcdcc into webpack:main Mar 26, 2026
9 checks passed
@mr-baraiya mr-baraiya deleted the refactor/sponsors-tailwind branch March 26, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants