refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095
refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095mr-baraiya wants to merge 14 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rahul-kr-rai
left a comment
There was a problem hiding this comment.
The current h1 heading appears to visually merge with the navbar
Please fix it.
alexander-akait
left a comment
There was a problem hiding this comment.
Please fix the above problem
|
Adjusted layout spacing by adding top padding to the section instead of margin on the heading. This ensures proper separation from the navbar. |
|
@rahul-kr-rai please take a look too |
But size of Please fix it. |
|
Updated the heading font size using exact pixel values from the original webpack.js.org design and aligned spacing with the original SCSS by using margin on the heading instead of section padding. |
Good, but the style is still different. You can open both links and see the exact difference by switching the tabs. Visit Here: ( https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and https://webpack.js.org/ ) Please fix it. |
|
I’ve worked on aligning the SplashViz section with the original Webpack design and was able to match most of the styling and behavior. However, the text rotation animation still shows a slight flicker/crack during transitions. I investigated multiple approaches (layout fixes, animation changes, font adjustments), but it appears to be caused by browser rendering limitations with text animations rather than implementation issues. Given this, I’m unable to fully eliminate the glitch while keeping the original behavior intact. I’d suggest either accepting the minor visual difference or switching to a fade-based animation for complete smoothness. Let me know how you’d like to proceed. |
The |
|
I’ve focused only on the SplashViz component and updated the styling to better match the original design. |
|
@rahul-kr-rai can you take a look too on these changes |
| <span> images </span> | ||
| <span> styles </span> | ||
| </TextRotator> | ||
| <section className="relative grid grid-rows-[auto_1fr] overflow-hidden p-4 pb-16 bg-[#2b3a42] dark:bg-gray-900 h-[clamp(35rem,calc(100vh-80px),45rem)] md:h-[clamp(30rem,calc(100vh-80px),35rem)] sm:min-h-[clamp(40rem,calc(100vh-80px),50rem)]"> |
There was a problem hiding this comment.
Can we use Clsx here?
| <section className="relative grid grid-rows-[auto_1fr] overflow-hidden p-4 pb-16 bg-[#2b3a42] dark:bg-gray-900 h-[clamp(35rem,calc(100vh-80px),45rem)] md:h-[clamp(30rem,calc(100vh-80px),35rem)] sm:min-h-[clamp(40rem,calc(100vh-80px),50rem)]"> | |
| className={clsx( | |
| "relative grid grid-rows-[auto_1fr] overflow-hidden p-4 pb-16", | |
| "bg-[#2b3a42] dark:bg-gray-900", | |
| // height utilities | |
| "h-[clamp(35rem,calc(100vh-80px),45rem)]", | |
| "md:h-[clamp(30rem,calc(100vh-80px),35rem)]", | |
| "sm:min-h-[clamp(40rem,calc(100vh-80px),50rem)]" | |
| )} |
There was a problem hiding this comment.
We should use clsx only when our classes are conditional, for example:
<section className={clsx(["foo", isOpen ? "open" : "close", isBig ? "big" : "small"])}>|
I have verified it locally all look good. If |
| "md:h-[clamp(30rem,calc(100vh-80px),35rem)]", | ||
| "sm:min-h-[clamp(40rem,calc(100vh-80px),50rem)]", | ||
| )} | ||
| > |
There was a problem hiding this comment.
@mr-baraiya let's remove clsx from here, no conditional classes and we can merge
|
@mr-baraiya please rebase main |
e4505ea to
884487f
Compare
|
Rebased on latest main |
|
@mr-baraiya Please look at https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and you will find that cube is not in center, to be honestly I tired to recheck everything every time, please verify your changes before pinging me, respect time of other developers |
|
See the difference: SplashViz.Review.mp4Please follow the instructions: Visit Here: ( https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and https://webpack.js.org/ ) Please fix it. |
|
Apologies for the earlier issues. I’ve tried to align the layout as closely as possible and verified the changes. Please let me know if this looks good, otherwise I understand if the PR needs to be closed. |
The same issue is still occurring. As per @mr-baraiya, he has been unable to resolve this, so I kindly request @alexander-akait to review and consider closing the PR. |
|
@rahul-kr-rai feel free to send your own solution, I will close this when merge the working migration in our main branch |
I have raised a PR #8127 to solve this issue. |
|
Fixed by #8127 |

Part of #8047
Changes
Notes