Skip to content

Add DocSearch button key theme styles for light and dark modes #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Deven14125 wants to merge 6 commits into from
Closed

Add DocSearch button key theme styles for light and dark modes #8076

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ef7cdb
Add DocSearch button key theme styles
Deven14125 Mar 20, 2026
51522a1
Use dark: utilities for DocSearch key styles
Deven14125 Mar 20, 2026
9a08b68
Use blue bg for DocSearch button in dark mode
Deven14125 Mar 20, 2026
393bc83
Adjust DocSearch button dark theme colors
Deven14125 Mar 21, 2026
97fea1c
Merge branch 'webpack:main' into fix-search-icon-color
Deven14125 Mar 21, 2026
64ac30f
Add dark theme styles for DocSearch modal
Deven14125 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/styles/tailwind.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@
.DocSearch-Button-Keys {
@apply hidden! lg:flex!;
}
.DocSearch-Button-Key {
@apply text-gray-700! bg-gray-100! border-gray-300!;
}
[data-theme="dark"] .DocSearch-Button-Key {
@apply text-gray-100! bg-olive-700! border-gray-500!;
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bg-olive-700 doesn’t appear to be a defined Tailwind color in this repo (tailwind.config.js only defines blue/gray/white/black/transparent). In dark mode this means the background utility won’t be generated, so the key can end up with text-gray-100 on the inherited light bg-gray-100 (very low contrast). Use an existing color token (e.g. one of the configured grays/blues) or extend the Tailwind theme to include olive shades before using bg-olive-700.

Suggested change
@apply text-gray-100! bg-olive-700! border-gray-500!;
@apply text-gray-100! bg-gray-700! border-gray-500!;

Copilot uses AI. Check for mistakes.
}
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already uses the custom dark variant via dark: utilities (e.g. .DocSearch-Button-Placeholder uses lg:dark:text-gray-300!), but here dark mode is handled with a separate [data-theme="dark"] .DocSearch-Button-Key selector. Consider folding the dark styles into the base rule with dark: utilities to keep the pattern consistent and reduce duplicated selectors.

Suggested change
@apply text-gray-700! bg-gray-100! border-gray-300!;
}
[data-theme="dark"] .DocSearch-Button-Key {
@apply text-gray-100! bg-olive-700! border-gray-500!;
}
@apply text-gray-700! bg-gray-100! border-gray-300! dark:text-gray-100! dark:bg-olive-700! dark:border-gray-500!;
}

Copilot uses AI. Check for mistakes.
.DocSearch-Button .DocSearch-Search-Icon {
@apply text-white! lg:text-gray-100!;
}
Loading