Skip to content

types: Restrict client property to false or ClientConfiguration#5660

Open
Mister-Hope wants to merge 1 commit intowebpack:mainfrom
Mister-Hope:patch-1
Open

types: Restrict client property to false or ClientConfiguration#5660
Mister-Hope wants to merge 1 commit intowebpack:mainfrom
Mister-Hope:patch-1

Conversation

@Mister-Hope
Copy link
Copy Markdown

client: true is never documented nor supported. It is confusing to support client: true in types.

Schema here:

"Client": {
"description": "Allows to specify options for client script in the browser or disable client script.",
"link": "https://webpack.js.org/configuration/dev-server/#devserverclient",
"anyOf": [
{
"enum": [false],
"cli": {
"negatedDescription": "Disables client script."
}
},
{
"type": "object",
"additionalProperties": false,
"properties": {
"logging": {
"$ref": "#/definitions/ClientLogging"
},
"overlay": {
"$ref": "#/definitions/ClientOverlay"
},
"progress": {
"$ref": "#/definitions/ClientProgress"
},
"reconnect": {
"$ref": "#/definitions/ClientReconnect"
},
"webSocketTransport": {
"$ref": "#/definitions/ClientWebSocketTransport"
},
"webSocketURL": {
"$ref": "#/definitions/ClientWebSocketURL"
}
}
}
]
},

Docs here:

https://webpack.js.org/configuration/dev-server/#devserverclient

Copilot AI review requested due to automatic review settings April 21, 2026 03:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 21, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Mister-Hope / name: Mister-Hope (0482c41)

@alexander-akait
Copy link
Copy Markdown
Member

Our types are auto generate, it means we have typo somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants