Skip to content

Stop privilege escalation by group leaders #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jotjern wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop privilege escalation by group leaders #4134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lego/apps/users/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,18 @@ class PreventPermissionElevation(LegoPermissions):
def has_permission(self, request, view):
if request.method in ["CREATE", "PUT", "PATCH"]:
user = request.user
requested_permissions = request.data.get("permissions", [])
requested_permissions = list(request.data.get("permissions", []))

parent_id = request.data.get("parent")
if parent_id:
from lego.apps.users.models import AbakusGroup

try:
parent = AbakusGroup.objects.get(id=parent_id)
except (AbakusGroup.DoesNotExist, ValueError, TypeError):
return False
for group in parent.get_ancestors(include_self=True):
requested_permissions += list(group.permissions)

if not user.has_perms(requested_permissions):
return False
Expand Down