Skip to content

Availability endpoint gives RequestId and Edit boolean#4120

Open
christiangryt wants to merge 2 commits into
masterfrom
availability-pass-requestid-and-edit-boolean
Open

Availability endpoint gives RequestId and Edit boolean#4120
christiangryt wants to merge 2 commits into
masterfrom
availability-pass-requestid-and-edit-boolean

Conversation

@christiangryt
Copy link
Copy Markdown
Contributor

Description

Availability endpoint passes RequestId and CanEdit fields along with old ones. For every unavailable range the corresponding LendingRequestId is passed as well as a permission check for the user making the request if they are allowed to make changes to said request.

Allows lending calender to link unavailable times (approved requests) to the actual request if the user has the permission to do so.

Changed Lending API test to accept answer length 6 to accommodate 2 extra fields being passed.

Testing

  • The code quality is at a minimum required level of quality, readability, and performance.
  • I have thoroughly tested my changes.

Ran all lego tests along with code style fixes.

Resolves webkom x bekk

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.65%. Comparing base (022a639) to head (560fac0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4120   +/-   ##
=======================================
  Coverage   82.64%   82.65%           
=======================================
  Files         359      359           
  Lines       12703    12705    +2     
=======================================
+ Hits        10499    10501    +2     
  Misses       2204     2204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant