Availability endpoint gives RequestId and Edit boolean#4120
Open
christiangryt wants to merge 2 commits into
Open
Availability endpoint gives RequestId and Edit boolean#4120christiangryt wants to merge 2 commits into
christiangryt wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4120 +/- ##
=======================================
Coverage 82.64% 82.65%
=======================================
Files 359 359
Lines 12703 12705 +2
=======================================
+ Hits 10499 10501 +2
Misses 2204 2204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Availability endpoint passes RequestId and CanEdit fields along with old ones. For every unavailable range the corresponding LendingRequestId is passed as well as a permission check for the user making the request if they are allowed to make changes to said request.
Allows lending calender to link unavailable times (approved requests) to the actual request if the user has the permission to do so.
Changed Lending API test to accept answer length 6 to accommodate 2 extra fields being passed.
Testing
Ran all lego tests along with code style fixes.
Resolves webkom x bekk