Add downlad attendee-csv-file EventViewSet#3811
Open
emillub wants to merge 1 commit into
Open
Conversation
emillub
force-pushed
the
add-export-participants-to-csv
branch
from
e3915d6 to
f2dec6b
Compare
1 task
emillub
force-pushed
the
add-export-participants-to-csv
branch
2 times, most recently
from
9c7d5dc to
7ceff55
Compare
jonasdeluna
approved these changes
Mar 26, 2025
| @decorators.action(detail=True, methods=["GET"]) | ||
| def csv(self, *args, **kwargs): | ||
| event = Event.objects.get(pk=kwargs["pk"]) | ||
| response = HttpResponse(content_type="text/csv") |
Member
There was a problem hiding this comment.
Maybe use Response instead like other places in our codebase for consistency?
emillub
force-pushed
the
add-export-participants-to-csv
branch
from
7ceff55 to
23ea776
Compare
emillub
force-pushed
the
add-export-participants-to-csv
branch
from
23ea776 to
1d59af9
Compare
Arashfa0301
requested changes
Mar 27, 2025
Contributor
Arashfa0301
left a comment
Arashfa0301
left a comment
There was a problem hiding this comment.
Very good job. Just some small nitpicks
Comment on lines
+363
to
+364
Contributor
There was a problem hiding this comment.
Could you remove these two
| ) | ||
|
|
||
| writer = csv.writer(response) | ||
| writer.writerow(["full_name", "username", "email", "phone", "grade"]) |
Contributor
There was a problem hiding this comment.
Why not phone_number here?
| event = Event.objects.get(pk=kwargs["pk"]) | ||
| response = HttpResponse(content_type="text/csv") | ||
| response["Content-Disposition"] = ( | ||
| f'attachment; filename="{event.title.replace(" ", "_") + "_attendees"}.csv"' |
Contributor
There was a problem hiding this comment.
Could you change this to filename="{event.title.replace(" ", "_") }_attendees.csv"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add csv action on EventViewSet
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-870