-
Notifications
You must be signed in to change notification settings - Fork 397
Feat/webinar llm latencies 2 #5002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tianhui-Han
wants to merge
34
commits into
webex:next
Choose a base branch
from
Tianhui-Han:feat/webinar_LLM_Latencies_2
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
ea8f007
feat(meetings,llm): add webinar LLM connect and locus sync latency di…
Tianhui-Han 47d0606
fix(meetings): emit breakout join response metric once per breakoutMo…
Tianhui-Han 838cc6f
Merge branch 'next' into feat/webinar_LLM_Latencies_2
Tianhui-Han 1b82b71
feat(meetings): add Locus sync latency metric callbacks
Tianhui-Han f15504d
refactor(meetings): simplify LLM metric payload construction
Tianhui-Han 3335dc8
refactor(metrics): align locus sync latency tracking with internal ti…
Tianhui-Han 35ba521
fix(metrics): record sync HTTP latency timestamps at request boundaries
Tianhui-Han e8311a9
refactor(metrics): simplify sync backoff tracking
Tianhui-Han 09d121a
Merge branch 'next' into feat/webinar_LLM_Latencies_2
Tianhui-Han f9875b0
fix(meetings): preserve breakout join metric without LLM latency
Tianhui-Han a4dbd7d
fix(meetings): preserve watchdog backoff in sync metrics
Tianhui-Han dc5d4e7
fix(meetings): retain sync metrics for empty sync responses
Tianhui-Han b06fcd0
fix(meetings): preserve syncAll backoff in sync metrics
Tianhui-Han d151ef7
fix(metrics): scope locus sync latency by meeting
Tianhui-Han b243dec
fix(meetings): dedupe breakout join response metrics
Tianhui-Han 7ceadf9
fix(meetings): track target sync version for metrics
Tianhui-Han 21e57ee
fix(meetings): avoid overwriting pending sync metrics
Tianhui-Han 839c876
Merge branch 'next' into feat/webinar_LLM_Latencies_2
Tianhui-Han f34a260
fix(meetings): preserve root sync backoff metrics
Tianhui-Han a36871d
fix(meetings): keep breakout LLM join metric from being deduped
Tianhui-Han 0d236ca
Merge branch 'next' into feat/webinar_LLM_Latencies_2
Tianhui-Han 70c8b96
fix: use heartbeat target version for single-leaf sync metrics
Tianhui-Han 0d54758
fix: add ts-ignore for webex property injected by registerPlugin
Tianhui-Han 97b7bff
fix: correlate sync metrics by LLM tracking id
Tianhui-Han c3b1a10
test(llm): assert registerAndConnect latency values precisely
Tianhui-Han 608910a
fix(metrics): require meeting id for locus sync latencies
Tianhui-Han 36a6303
refactor(metrics): share locus sync latency event definitions
Tianhui-Han 528c821
refactor(meetings): use callbacks sync latency tracker directly
Tianhui-Han a0ef7ee
refactor(meetings): use updateMeeting callback from callbacks
Tianhui-Han 4356f3d
fix(meetings): guard breakout LLM join metrics
Tianhui-Han 444d4c5
refactor(meetings): simplify LLM metric payload construction
Tianhui-Han 051bbd7
fix(plugin-meetings): report locus sync complete metrics from parser …
Tianhui-Han fdddb7f
fix(metrics): complete locus sync latency via sync response callback
Tianhui-Han 051343e
Merge branch 'next' into feat/webinar_LLM_Latencies_2
Tianhui-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the datachannel registration succeeds but the websocket
connect()rejects, this method rejects before returning the already-measuredclientLLMDatachannelResponseTime; the caller’s catch path then reports both LLM connect latencies as0. In websocket-failure scenarios this corrupts the newclient.llm.connect.responsefailure telemetry by losing the registration response time that was actually observed.Useful? React with 👍 / 👎.