Skip to content

[Gecko Bug 2046559] Make scroll timeline lookups loosely matched scoped name matching. #61383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moz-wptsync-bot wants to merge 1 commit into
base: master
Choose a base branch
from
+56 −55
Open

[Gecko Bug 2046559] Make scroll timeline lookups loosely matched scoped name matching. #61383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions scroll-animations/css/scroll-timeline-name-shadow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<link rel="help" src="https://drafts.csswg.org/scroll-animations-1/#scroll-timelines-named">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/8135">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/8192">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/13974">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/web-animations/testcommon.js"></script>
Expand Down Expand Up @@ -55,8 +56,8 @@
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Outer animation can see scroll timeline defined by :host');
assert_equals(anim.timeline.axis, 'x');
}, 'Outer animation can not see scroll timeline defined by :host');
</script>


Expand Down Expand Up @@ -93,8 +94,8 @@
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Outer animation can see scroll timeline defined by ::slotted');
assert_equals(anim.timeline.axis, 'x');
}, 'Outer animation can not see scroll timeline defined by ::slotted');
</script>


Expand Down Expand Up @@ -139,42 +140,42 @@
}, 'Inner animation can see scroll timeline defined by ::part');
</script>


<template id=scroll_timeline_shadow>
<template id=scroll_timeline_scoped_ancestor>
<style>
.target {
animation: anim 10s linear;
animation-timeline: --timeline;
}
.host {
scroll-timeline: --timeline x;
.scroller {
scroll-timeline: --timeline;
}
</style>
<div class=scroller>
<div class=host>
<div id=outer_host>
<template shadowrootmode=open shadowrootclonable>
<style>
div {
scroll-timeline: --timeline y;
}
</style>
<div>
<slot></slot>
<div id=inner_host>
<template shadowrootmode=open shadowrootclonable>
<style>
/* Technically also loosely matched, but... */
@keyframes anim2 {
from { z-index: 100; }
to { z-index: 100; }
}

.target {
animation: anim2 10s linear;
animation-timeline: --timeline;
}
</style>
<div class=target></div>
</template>
</div>
</template>
<div class=target></div>
</div>
</div>
<style>
</style>
</template>
<script>
promise_test(async (t) => {
inflate(t, scroll_timeline_shadow);
let target = main.querySelector('.target');
inflate(t, scroll_timeline_scoped_ancestor);
let target = outer_host.shadowRoot.querySelector('#inner_host').shadowRoot.querySelector('.target');
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Slotted element can see scroll timeline within the shadow');
}, 'Animation inside shadow DOM can see the scroll timeline defined by the ancestor DOM');
</script>
56 changes: 28 additions & 28 deletions scroll-animations/css/view-timeline-name-shadow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<link rel="help" src="https://drafts.csswg.org/scroll-animations-1/#view-timelines-named">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/8135">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/8192">
<link rel="help" src="https://github.com/w3c/csswg-drafts/issues/13974">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/web-animations/testcommon.js"></script>
Expand All @@ -22,7 +23,6 @@
}
</style>


<template id=view_timeline_host>
<style>
.target {
Expand Down Expand Up @@ -56,8 +56,8 @@
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Outer animation can see view timeline defined by :host');
assert_equals(anim.timeline.axis, 'x');
}, 'Outer animation can not see view timeline defined by :host');
</script>


Expand Down Expand Up @@ -94,8 +94,8 @@
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Outer animation can see view timeline defined by ::slotted');
assert_equals(anim.timeline.axis, 'x');
}, 'Outer animation can not see view timeline defined by ::slotted');
</script>


Expand Down Expand Up @@ -140,42 +140,42 @@
}, 'Inner animation can see view timeline defined by ::part');
</script>


<template id=view_timeline_shadow>
<template id=view_timeline_scoped_ancestor>
<style>
.target {
animation: anim 10s linear;
animation-timeline: --timeline;
}
.host {
view-timeline: --timeline x;
#outer_host {
view-timeline: --timeline;
}
</style>
<div class=scroller>
<div class=host>
<div id=outer_host>
<template shadowrootmode=open shadowrootclonable>
<style>
div {
view-timeline: --timeline y;
}
</style>
<div>
<slot></slot>
<div id=inner_host>
<template shadowrootmode=open shadowrootclonable>
<style>
/* Technically also loosely matched, but... */
@keyframes anim {
from { z-index: 100; }
to { z-index: 100; }
}

.target {
animation: anim 10s linear;
animation-timeline: --timeline;
}
</style>
<div class=target></div>
</template>
</div>
</template>
<div class=target></div>
</div>
</div>
<style>
</style>
</template>
<script>
promise_test(async (t) => {
inflate(t, view_timeline_shadow);
let target = main.querySelector('.target');
inflate(t, view_timeline_scoped_ancestor);
let target = outer_host.shadowRoot.querySelector('#inner_host').shadowRoot.querySelector('.target');
assert_equals(target.getAnimations().length, 1);
let anim = target.getAnimations()[0];
assert_not_equals(anim.timeline, null);
assert_equals(anim.timeline.axis, 'y');
}, 'Slotted element can see view timeline within the shadow');
}, 'Animation inside shadow DOM can see the view timeline defined by the ancestor DOM');
</script>
Loading