Skip to content

Generate .dist.yml where compat_features are sourced from BCD#797

Merged
foolip merged 5 commits intoweb-platform-dx:mainfrom
foolip:dist
Apr 9, 2024
Merged

Generate .dist.yml where compat_features are sourced from BCD#797
foolip merged 5 commits intoweb-platform-dx:mainfrom
foolip:dist

Conversation

@foolip
Copy link
Copy Markdown
Collaborator

@foolip foolip commented Apr 6, 2024

These are cases where the source YAML doesn't include compat_features,
but the generated .dist.yml does, based on BCD tags.

These are cases where the source YAML doesn't include compat_features,
but the generated .dist.yml does, based on BCD tags.
Copy link
Copy Markdown
Collaborator Author

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review to verify or reject the generated statuses.

spec: https://w3c.github.io/device-posture/
status:
baseline: false
support: {}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status:
baseline: false
support:
chrome: "121"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct: https://chromiumdash.appspot.com/commit/a47af0e3c56326a452b03fb588ac5ce09d484004

But it should also be supported in Chrome for Android AFAICT, so this needs investigating.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baseline: high
baseline_low_date: 2021-04-26
baseline_high_date: 2023-10-26
support:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions all match https://caniuse.com/flexbox-gap

Comment thread feature-group-definitions/ic.dist.yml Outdated
description: The CSS `ic` unit corresponds to the width of CJK ideographic characters.
spec: https://drafts.csswg.org/css-values-4/#ic
status:
baseline: false
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't baseline because of the CSS.ic() static method not being implemented in Firefox:
https://developer.mozilla.org/en-US/docs/Web/API/CSS#browser_compatibility

But this isn't really preventing its use in a vast majority of cases. I think we should remove api.CSS.ic_static from this feature or use an editorial override.

Comment thread feature-group-definitions/lh.dist.yml Outdated
description: The CSS `lh` unit corresponds to the requested line height, the computed value of the `line-height` property. Some lines may be higher than this based on their content.
spec: https://drafts.csswg.org/css-values-4/#lh
status:
baseline: false
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status:
baseline: low
baseline_low_date: 2023-03-27
support:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like finding a four-leaf clover 😆

status:
baseline: false
support:
chrome: "122"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caniuse: temporal
status:
baseline: false
support: {}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caniuse: web-bluetooth
status:
baseline: false
support: {}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, needs splitting out and investigating.

caniuse: midi
status:
baseline: false
support: {}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect.

@foolip foolip requested a review from ddbeck April 6, 2024 08:42
status:
baseline: low
baseline_low_date: 2023-03-27
support:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like finding a four-leaf clover 😆

@ddbeck
Copy link
Copy Markdown
Collaborator

ddbeck commented Apr 9, 2024

@foolip rebase needed here, otherwise ready to go. Thank you!

@foolip foolip merged commit 0b0bc11 into web-platform-dx:main Apr 9, 2024
@foolip foolip deleted the dist branch April 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants