fix(notifications): scrollable channel modal and email TLS cert bypass - #74
Open
alexneo2003 wants to merge 3 commits into
Open
fix(notifications): scrollable channel modal and email TLS cert bypass#74alexneo2003 wants to merge 3 commits into
alexneo2003 wants to merge 3 commits into
Conversation
Fixes #73: the Add Notification Channel modal had no max-height or scroll handling, so on shorter browser windows the Email channel's Advanced section pushed the Next/Cancel footer off-screen. The dialog now caps at 85vh and scrolls its form body while keeping the header and footer pinned, matching the pattern already used by ContainerLogsDialog and VersionPickerModal. Fixes #72: adds an "Allow invalid/self-signed certificates" option to the Email channel, so users connecting to internal SMTP servers with self-signed certs or certs presented for a different hostname (e.g. a NAT'd mail server) can opt out of TLS certificate validation. Default behavior (strict validation) is unchanged.
Contributor
🧪 Test Results — ✅ All tests passed
Commit: |
fail-fast: false so a transient failure building one service (e.g. the GitHub Actions cache "failed to reserve cache" flake) no longer cancels the other two mid-push, leaving a partial/incomplete beta release. cache-to mode=max -> mode=min reduces the volume of cache blobs written per multi-arch build, lowering the odds of hitting that same GHA cache write error again.
This was referenced Aug 4, 2026
…lanning-5aglf3 # Conflicts: # .github/workflows/pr-beta.yml
Contributor
Author
|
/pr-beta |
Contributor
🐳 PR Beta Images Published
Commit: Quick test# Pull and run
docker pull ghcr.io/watchwarden-labs/watchwarden-controller:pr-74-beta
docker pull ghcr.io/watchwarden-labs/watchwarden-agent:pr-74-beta
docker pull ghcr.io/watchwarden-labs/watchwarden-ui:pr-74-beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73: the Add Notification Channel modal had no max-height or
scroll handling, so on shorter browser windows the Email channel's
Advanced section pushed the Next/Cancel footer off-screen. The dialog
now caps at 85vh and scrolls its form body while keeping the header
and footer pinned, matching the pattern already used by
ContainerLogsDialog and VersionPickerModal.
Fixes #72: adds an "Allow invalid/self-signed certificates" option to
the Email channel, so users connecting to internal SMTP servers with
self-signed certs or certs presented for a different hostname (e.g. a
NAT'd mail server) can opt out of TLS certificate validation. Default
behavior (strict validation) is unchanged.