fix(workload): skip registering wasi 0.2 interfaces in resolved workload#72
fix(workload): skip registering wasi 0.2 interfaces in resolved workload#72jtakakura wants to merge 1 commit into
Conversation
8647164 to
197996d
Compare
|
@brooksmtownsend I have added regex to the dependencies.
|
|
Hey @jtakakura thank you so much for taking this on! Quite honestly, I need to give it a better look, but I would suggest holding off for now because #73 is going to cause you pain here to rebase. Hope that's ok! |
|
@brooksmtownsend Thank you for your reply! |
|
Okay @jtakakura ready to go! Thank you for your patience, #73 now merged |
0ea6569 to
cc46059
Compare
|
@brooksmtownsend Thank you for merging #73! Also, I have two questions about my implementation:
Let me know what you think! |
31d7cca to
baa8f0b
Compare
598defb to
862e338
Compare
60a702e to
ca3a448
Compare
cde91af to
66d770d
Compare
bbacfdb to
d04e87b
Compare
d04e87b to
fcbbfbb
Compare
Signed-off-by: Junji Takakura <j.takakura@gmail.com>
39beaf0 to
3e1552d
Compare
|
This repository has been merged into wasmCloud/wasmCloud. Please re-open this PR against wasmCloud/wasmCloud:main. |
Feature or Problem
This pull request updates the plugin registration logic in the workload resolution process to skip registering WASI@0.2 interfaces, in addition to the existing
wasmcloud:wash/pluginfilter. After the refactor in #73, the registration flow is now implemented within the workload engine, and no longer usesDevPluginManager. The change ensures that unnecessary or conflicting registrations of WASI@0.2 interfaces—which are generally provided by the runtime—are prevented.Related Issues
Fixes #11
Release Information
next
Consumer Impact
There should be no impact on consumers or dependents. The change only affects internal plugin registration logic and does not alter any public APIs or behavior for plugin authors.
Testing
Unit Test(s)
Unit tests were added to verify that WASI@0.2 interfaces are correctly skipped during registration in the refactored workload engine logic. (See
test_resolve_with_plugins_successincrates/wash-runtime/src/engine/workload.rs.)Acceptance or Integration
No changes to acceptance or integration tests were required.
Manual Verification