Skip to content

Add missing scrollToTop prop to accordion filter#690

Open
llfalcao wants to merge 1 commit into
vtex-apps:masterfrom
llfalcao:fix/accordion-price-range-scroll
Open

Add missing scrollToTop prop to accordion filter#690
llfalcao wants to merge 1 commit into
vtex-apps:masterfrom
llfalcao:fix/accordion-price-range-scroll

Conversation

@llfalcao

@llfalcao llfalcao commented Nov 29, 2024

Copy link
Copy Markdown

What problem is this solving?

The scrollToTop prop isn't passed down to the PriceRange component when the collapsible navigation type is applied to the filter navigator, causing the window to scroll to the top when query params are updated, even when the prop is set to "none".

How to test it?

Using any component that updates the query params with setQuery, from render-runtime.

Workspace (before)
Workspace (after)

Screenshots or example usage:

Before

screen-capture.webm

After

screen-capture.1.webm

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

@llfalcao llfalcao requested review from a team as code owners November 29, 2024 05:12
@llfalcao llfalcao requested review from gabpaladino, leo-prange-vtex and vsseixaso and removed request for a team November 29, 2024 05:12
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@llfalcao

llfalcao commented Jan 6, 2025

Copy link
Copy Markdown
Author

I can't mark any of these options, but it's a patch and there's nothing new to document.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant