feat: add ModelServing revision core - #1643
Open
acsoto wants to merge 4 commits into
Open
Conversation
volcano-sh-bot
requested review from
YaoZengzeng,
git-malu,
hzxuzhonghu and
kube-gopher
August 17, 2026 12:28
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
LiZhenCheng9527
moved this from Accepted
to Planned in Release v1.1
in Kthena Release Tracking
Member
Author
kube-gopher
reviewed
Aug 22, 2026
Comment on lines
+167
to
+168
| if clone.Revision >= newRevision { | ||
| return nil |
Member
There was a problem hiding this comment.
Suggest: Do not report success after a failed conflict refresh
Signed-off-by: Zhou Zihang <z@mcac.cc>
Signed-off-by: Zhou Zihang <z@mcac.cc>
Signed-off-by: Zhou Zihang <z@mcac.cc>
Signed-off-by: Zhou Zihang <z@mcac.cc>
acsoto
force-pushed
the
feature/modelserving-revision-core
branch
from
August 23, 2026 02:52
2d8a095 to
ac70d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements the first part of the ModelServing revision history and rollback proposal in #1607: revision API fields, canonical revision data and apply logic, and ControllerRevision lifecycle utilities.
Which issue(s) this PR fixes:
Refs #1607 #1584
Bug evidence (required for bug-related PRs):
N/A
Special notes for your reviewer:
This is part 1 of #1607. Controller integration, retention, and CLI rollback will follow separately.
This PR was written in part with the assistance of generative AI.
Does this PR introduce a user-facing change?: