chart: enable workloadmanager auth - #433
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces authentication configuration for the AgentCube Workload Manager, enabling the --enable-auth flag and setting up RBAC permissions for the router service account to manage sandboxes and sandboxclaims. The review feedback recommends replacing the proposed ClusterRole and ClusterRoleBinding with namespace-scoped Role and RoleBinding resources to adhere to the principle of least privilege and prevent naming conflicts in multi-namespace deployments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
small chart-side fix for this. Found that just passing --enable-auth was not enough, since WorkloadManager uses the caller token after auth is enabled. Added the minimal fix @acsoto @JesseStutler PTAL, when get chance. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 58.41% 58.50% +0.08%
==========================================
Files 36 36
Lines 3463 3463
==========================================
+ Hits 2023 2026 +3
+ Misses 1231 1228 -3
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
88c3527 to
6bde635
Compare
|
With auth enabled, sandbox creation in any other namespace will fail even though the Router API accepts a workload namespace. |
Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
6bde635 to
fe295b6
Compare
|
@acsoto i agree, updated it and release-prefixed the ClusterRole/Binding names to avoid install collisions |
|
I’m not sure enabling the current |
|
I’ll rework this so WM uses the token only to authenticate the Router call and keeps using its own service account for sandbox create/delete. That should also let us drop the extra Router RBAC from this PR, What do u think? |
|
I'm not sure what kind of permission behavior we're expecting right now, so I don't know how to make a recommendation. |
|
@acsoto fair enough. since the expected auth/RBAC model isn’t clear yet, closing this PR for now. We can reopen this later once the intended WM auth model is settled. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Enables WorkloadManager auth in the base chart. The chart already has Router call WorkloadManager with its service account token, but WorkloadManager was not started with
--enable-auth.Also grants Router the minimal sandbox create/delete RBAC needed once WorkloadManager starts using the caller token.
Which issue(s) this PR fixes:
Fixes #432
Special notes for your reviewer:
Helm is not installed in my local env, so I could not run
helm templateorhelm lint. I did rungit diff --cached --checkbefore committing.Does this PR introduce a user-facing change?: