fix(check): respect oxlint exit code so denyWarnings fails vp check#1425
fix(check): respect oxlint exit code so denyWarnings fails vp check#1425
vp check#1425Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f6466c2. Configure here.
`vp check` was unconditionally resetting the status to success whenever lint reported only warnings, masking the non-zero exit code produced by oxlint when `options.denyWarnings` (or `--deny-warnings`) is enabled. Drop the override and trust oxlint's exit code so warning-only runs fail the check when warnings have been opted in as failures. Closes #1424
f6466c2 to
bcd1a84
Compare
cpojer
left a comment
There was a problem hiding this comment.
I didn't know this feature existed when I built the vp check wrapper for oxlint.
I don't know why this feature exits in oxlint tbh, wouldn't it be better to force people to just set their lint rules to "error"?
Many of the built-in rules are configured as warn by default. By setting |
|
Yeah, I understand that, but imho the problem is that the concept of a warning exists at all in Oxlint. There should only be errors. |
|
vinext ci fails fix: cloudflare/vinext#864 |

vp checkwas unconditionally resetting the status to success wheneverlint reported only warnings, masking the non-zero exit code produced by
oxlint when
options.denyWarnings(or--deny-warnings) is enabled.Drop the override and trust oxlint's exit code so warning-only runs fail
the check when warnings have been opted in as failures.
Closes #1424
Note
Medium Risk
Changes
vp checkexit-code behavior for warning-only lint results, which can cause previously-passing pipelines to fail whendenyWarningsis enabled. Scope is small and localized to the check command plus a new regression snap-test.Overview
vp checkno longer forces a success exit status when oxlint reports only warnings; it now propagates oxlint’s actual exit code solint.options.denyWarnings(or--deny-warnings) correctly fails the check.Adds a new snap-test fixture
check-lint-warn-deny-warningsthat configuresdenyWarnings: truewith a warning-levelno-consolerule and asserts the expected warning output and summary.Reviewed by Cursor Bugbot for commit f6466c2. Configure here.