-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
sync.stdatomic: add GCC 15/16 libatomic paths for TCC on Linux #28044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nepinhum
wants to merge
2
commits into
vlang:master
Choose a base branch
from
nepinhum:fix/stdatomic-tcc-gcc16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−11
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import os | ||
| import rand | ||
|
|
||
| const vexe = @VEXE | ||
|
|
||
| const stdatomic_program = ' | ||
| module main | ||
|
|
||
| import sync.stdatomic | ||
|
|
||
| fn main() { | ||
| mut a := stdatomic.new_atomic(i64(0)) | ||
| a.store(1) | ||
| println(a.load()) | ||
| assert a.compare_and_swap(1, 2) | ||
| println(a.load()) | ||
| println(a.add(3)) | ||
| println(a.load()) | ||
| } | ||
| ' | ||
|
|
||
| // This is a regression test for https://github.com/vlang/v/issues/28043 (and similar reports), | ||
| // where TCC failed to link sync.stdatomic programs on Linux/amd64 systems with newer GCC | ||
| // versions (e.g. GCC 15/16 on Arch Linux). | ||
| fn test_tcc_can_link_sync_stdatomic_programs_on_linux() { | ||
| $if !(linux && (amd64 || arm64)) { | ||
| return | ||
| } | ||
| workdir := os.join_path(os.vtmp_dir(), 'v_stdatomic_tcc_libatomic_${rand.ulid()}') | ||
| os.mkdir_all(workdir) or { panic(err) } | ||
| defer { | ||
| os.rmdir_all(workdir) or {} | ||
| } | ||
| vcache := os.join_path(workdir, 'vcache') | ||
| os.mkdir_all(vcache) or { panic(err) } | ||
| src := os.join_path(workdir, 'main.v') | ||
| out := os.join_path(workdir, 'main') | ||
| os.write_file(src, stdatomic_program) or { panic(err) } | ||
|
|
||
| compile_cmd := 'env VCACHE=${os.quoted_path(vcache)} ${os.quoted_path(vexe)} -nocache -cc tcc -no-retry-compilation -showcc -o ${os.quoted_path(out)} ${os.quoted_path(src)}' | ||
| compile_res := os.execute(compile_cmd) | ||
| if compile_res.exit_code != 0 { | ||
| panic('tcc compilation of a sync.stdatomic program failed (fallback to another compiler is disabled):\ncmd: ${compile_cmd}\noutput:\n${compile_res.output}') | ||
| } | ||
| assert !compile_res.output.contains('falling back to cc') | ||
|
|
||
| run_res := os.execute(os.quoted_path(out)) | ||
| assert run_res.exit_code == 0 | ||
| assert run_res.output.trim_space() == '1\n2\n2\n5' | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add/restore the Debian/Ubuntu amd64 candidates here as well:
/usr/lib/gcc/x86_64-linux-gnu/{6..16}/libatomic.a. GCC installslibatomic.aunder this target triple on Debian-family x86_64 systems, and this block currently has no matching entry (unlike the arm64 block). Without those paths, the same__atomic_*_8link failure remains on Debian/Ubuntu systems using GCC 15/16.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alr, sent a new commit / done.