feat: allow overriding rolldown version#450
Merged
Conversation
Collaborator
|
how long does rolldown build take, maybe we can use the |
Member
Author
|
It seems it takes around 4 minutes |
Collaborator
|
4min is a bit steep, do you automatically deploy rolldown to pr.new? I remember a previous discussion about consuming vite builds from there and it gets a little tricky with knowing when/if a hash is available there. As long as this is only for our internal manual use and not affecting scheduled runs it may be fine, similar to the other vite plugin inputs we already have, but i'd like to avoid those getting out of hand. |
dominikg
reviewed
Mar 17, 2026
dominikg
reviewed
Mar 17, 2026
Member
Author
I was only thinking about manually triggering this workflow before releasing rolldown. |
dominikg
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a way to override rolldown version. This would be helpful to test the latest Rolldown version before releasing Rolldown.
It requires the pkg.pr.new package to be published for that commit.