Skip to content

feat: allow overriding rolldown version#450

Merged
dominikg merged 2 commits intomainfrom
feat/allow-overriding-rolldown-version
Mar 25, 2026
Merged

feat: allow overriding rolldown version#450
dominikg merged 2 commits intomainfrom
feat/allow-overriding-rolldown-version

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Mar 14, 2026

Added a way to override rolldown version. This would be helpful to test the latest Rolldown version before releasing Rolldown.

It requires the pkg.pr.new package to be published for that commit.

@dominikg
Copy link
Copy Markdown
Collaborator

how long does rolldown build take, maybe we can use the builds directory for it instead?

@sapphi-red
Copy link
Copy Markdown
Member Author

It seems it takes around 4 minutes

@dominikg
Copy link
Copy Markdown
Collaborator

4min is a bit steep, do you automatically deploy rolldown to pr.new? I remember a previous discussion about consuming vite builds from there and it gets a little tricky with knowing when/if a hash is available there.

#354

As long as this is only for our internal manual use and not affecting scheduled runs it may be fine, similar to the other vite plugin inputs we already have, but i'd like to avoid those getting out of hand.

Comment thread utils.ts Outdated
Comment thread utils.ts Outdated
@sapphi-red
Copy link
Copy Markdown
Member Author

4min is a bit steep, do you automatically deploy rolldown to pr.new?

I was only thinking about manually triggering this workflow before releasing rolldown.

@dominikg dominikg merged commit e0b358d into main Mar 25, 2026
4 checks passed
@dominikg dominikg deleted the feat/allow-overriding-rolldown-version branch March 25, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants