Silicon implementation of new backend-independent counterexample format#940
Open
marcoeilers wants to merge 20 commits into
Open
Silicon implementation of new backend-independent counterexample format#940marcoeilers wants to merge 20 commits into
marcoeilers wants to merge 20 commits into
Conversation
marcoeilers
marked this pull request as ready for review
July 15, 2026 22:32
marcoeilers
commented
Jul 21, 2026
| case AtMost(t0, t1) => intComparison(t0, t1, model, env)(_ <= _) | ||
| case AtLeast(t0, t1) => intComparison(t0, t1, model, env)(_ >= _) | ||
| case Less(t0, t1) => intComparison(t0, t1, model, env)(_ < _) | ||
| case t: Greater => intComparison(t.p0, t.p1, model, env)(_ > _) |
Contributor
Author
There was a problem hiding this comment.
case Greater(t0, t1) =>
| @@ -0,0 +1,1157 @@ | |||
| package viper.silicon.reporting | |||
| import viper.silver.verifier.Rational | ||
|
|
||
| /** | ||
| * Transforms a counterexample returned by Boogie back to a Viper counterexample. The programmer can choose between an |
Contributor
Author
There was a problem hiding this comment.
Adjust names here and in comment below
| } | ||
|
|
||
| /** | ||
| * CounterexampleGenerator class used for generating an "intermediate" CE. |
Contributor
Author
There was a problem hiding this comment.
intermediate -> raw
| } | ||
| case c@MagicWandChunk(_, _, _, _, _, _, _) => | ||
| heap += detMagicWand(model, c) | ||
| case _ => //println("This case is not supported in detHeap") |
Contributor
Author
There was a problem hiding this comment.
Drop, add quantified wand chunk case
| /** | ||
| * Compare the snapshot of a predicate to its actual body (accessed through its ast node). | ||
| */ | ||
| def evalBody(exp: Exp, value: ModelEntry, lookup: scala.collection.immutable.Map[Exp, ModelEntry]): (Exp, ModelEntry) = { |
Contributor
Author
There was a problem hiding this comment.
Adjust naming to clarify difference between this and term evaluation above.
| } | ||
| } | ||
|
|
||
| def evalSnap(term: Term, model: Model): Seq[ModelEntry] = term match { |
Contributor
Author
There was a problem hiding this comment.
Is this still needed?
| /** | ||
| * Evaluates a Term to a value of the counterexample from the SMT solver. | ||
| */ | ||
| def evalTermToModelEntry(value: Term, model: Model): Option[ModelEntry] = { |
Contributor
Author
There was a problem hiding this comment.
Is this still needed?
| // Inline pTaken (instead of defining a macro) when a counterexample is requested, so that the | ||
| // chunk's permission term contains proper permission arithmetic the counterexample machinery | ||
| // can evaluate, rather than an opaque macro application. | ||
| val declareMacro = s.functionRecorder == NoopFunctionRecorder && Verifier.config.counterexample.toOption.isEmpty // && !Verifier.config.useFlyweight |
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| // | ||
| // Copyright (c) 2011-2025 ETH Zurich. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silicon implementation of the new backend-independent counterexample format (see viperproject/silver#883), written by @rvandoren in his practical work project.