fix(react): send a pageview when route is set without a path (#197) - #205
Open
sarmah-rup wants to merge 1 commit into
Open
fix(react): send a pageview when route is set without a path (#197)#205sarmah-rup wants to merge 1 commit into
sarmah-rup wants to merge 1 commit into
Conversation
|
@sarmah-rup is attempting to deploy a commit to the Analytics Test Projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I hit
Using
<Analytics route="/blog/[slug]" />(aroute, nopath— the normal React Router / TanStack Router pattern), zero pageviews were tracked, silently. This is issue #197.Why
The mount effect sets
disableAutoTrack: trueas soon asrouteis defined, turning off the script's own pageview tracking. But the manual pageview effect only fires when bothroute && pathare truthy. So with arouteand nopath, auto-track is disabled and the manual call is skipped, so nothing is tracked, with no warning.Fix
Fire the manual pageview whenever
routeis set (the exact condition under which auto-track was disabled), defaultingpathtowindow.location.pathnamewhen it is omitted. The Next.js and Remix wrappers always pass both, so they are unaffected.Test
Added two cases to
react/index.test.tsx: the route-without-path case now queues a pageview, and a both-provided regression guard. Verified fail before the fix / pass after against the real component.Closes #197.