fix(reflect): cap structured output retry budget#2433
Open
koriyoshi2041 wants to merge 1 commit into
Open
Conversation
ccef070 to
689633f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflect_structuredextraction retry budget so provider-specific empty structured-output responses do not consume the full reflect timeoutContext
This is motivated by #2431, where plain reflect can succeed while
response_schematriggers repeated empty provider responses withfinish_reason=length.Tests
uv run pytest tests/test_reflect_agent.py::TestReflectStructuredOutput::test_structured_output_uses_short_retry_budget -quv run ruff check hindsight_api/engine/reflect/agent.py tests/test_reflect_agent.pyuv run ruff format --check hindsight_api/engine/reflect/agent.py tests/test_reflect_agent.pygit diff --checkNote: full
uv run pytest tests/test_reflect_agent.py -qreached 50 passing tests, then hit local environment setup errors unrelated to this patch: missingHINDSIGHT_API_LLM_API_KEYfor real-LLM tests and a local SOCKS proxy requiringsocksioduring Hugging Face model initialization.