Conversation
Six use cases exercising Page#shareSupportSignal() and Page#share(...) from vaadin/flow#24325: share this page, copy-link fallback, custom message, per-item share in a list, completion feedback, and invite link. Includes browserless tests, Fly deployment config, and an API-GAPS.md noting the file-share / canShare / test-simulator gaps surfaced while building the demos.
The lambda in viewRendersHeadingAndButtons() concatenated a literal with `.equals(...)`, so the predicate returned String instead of boolean and broke compilation. Group the heading literal so the equals call applies to the full string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six use cases exercising Page#shareSupportSignal() and Page#share(...) from vaadin/flow#24325: share this page, copy-link fallback, custom message, per-item share in a list, completion feedback, and invite link. Includes browserless tests, Fly deployment config, and an API-GAPS.md noting the file-share / canShare / test-simulator gaps surfaced while building the demos.