-
Notifications
You must be signed in to change notification settings - Fork 202
feat: Add Screen Orientation API support to Page #24327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Artur-
wants to merge
3
commits into
main
Choose a base branch
from
feature/screen-orientation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * Copyright 2000-2026 Vaadin Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| type VaadinScreenOrientationType = | ||
| | 'portrait-primary' | ||
| | 'portrait-secondary' | ||
| | 'landscape-primary' | ||
| | 'landscape-secondary'; | ||
|
|
||
| interface VaadinScreenOrientationDetail { | ||
| type: VaadinScreenOrientationType | ''; | ||
| angle: number; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the current screen orientation type synchronously, or | ||
| * {@code 'unsupported'} if the Screen Orientation API is unavailable. Used by | ||
| * the bootstrap path to seed the server-side signal without waiting for a DOM | ||
| * event. | ||
| */ | ||
| export function currentScreenOrientationType(): string { | ||
| return screen.orientation?.type ?? 'unsupported'; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the current screen orientation angle synchronously, or 0 if the | ||
| * Screen Orientation API is unavailable. | ||
| */ | ||
| export function currentScreenOrientationAngle(): number { | ||
| return screen.orientation?.angle ?? 0; | ||
| } | ||
|
|
||
| // Dispatch on document.body so the server-side Page facade (listening on the | ||
| // UI element, which is body) can update its signal. | ||
| function dispatch(detail: VaadinScreenOrientationDetail): void { | ||
| document.body.dispatchEvent(new CustomEvent('vaadin-screen-orientation-change', { detail })); | ||
| } | ||
|
|
||
| if (screen.orientation) { | ||
| screen.orientation.addEventListener('change', () => { | ||
| dispatch({ | ||
| type: screen.orientation.type as VaadinScreenOrientationType, | ||
| angle: screen.orientation.angle | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| const $wnd = window as any; | ||
| $wnd.Vaadin ??= {}; | ||
| $wnd.Vaadin.Flow ??= {}; | ||
| interface VaadinScreenOrientationLockResult { | ||
| success: boolean; | ||
| name?: string; | ||
| message?: string; | ||
| } | ||
|
|
||
| $wnd.Vaadin.Flow.screenOrientation = { | ||
| // Always resolves so the server-side .then(success, error) chain only | ||
| // receives the "error" branch on a bridge failure (lost connection, etc.). | ||
| // Rejected DOMExceptions are folded into the resolved result so the server | ||
| // can decode them as a record without forfeiting the JS-bridge error arm. | ||
| lock(type: string): Promise<VaadinScreenOrientationLockResult> { | ||
| if (!screen.orientation || typeof screen.orientation.lock !== 'function') { | ||
| return Promise.resolve({ | ||
| success: false, | ||
| name: 'NotSupportedError', | ||
| message: 'Screen Orientation API is not supported in this browser.' | ||
| }); | ||
| } | ||
| return screen.orientation | ||
| .lock(type as OrientationLockType) | ||
| .then(() => ({ success: true })) | ||
| .catch((e: DOMException) => ({ | ||
| success: false, | ||
| name: e.name ?? 'UnknownError', | ||
| message: e.message ?? '' | ||
| })); | ||
| }, | ||
| unlock(): void { | ||
| screen.orientation?.unlock(); | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be getScreenOrientationSignal()
Also does the method name need the Signal at the end as the return type is Signal?