install: fix EEXIST race losing files in parallel install -D#12429
Open
eyupcanakman wants to merge 2 commits into
Open
install: fix EEXIST race losing files in parallel install -D#12429eyupcanakman wants to merge 2 commits into
eyupcanakman wants to merge 2 commits into
Conversation
Concurrent install -D invocations sharing parent directories race in open_or_create_subdir between stat_at returning NotFound and mkdir_at. Another process can create the directory in that gap, so our mkdir_at returns EEXIST. Retry the stat to open the directory the other process created. Fixes uutils#12355.
|
GNU testsuite comparison: |
sylvestre
reviewed
May 23, 2026
| )), | ||
| }; | ||
| } | ||
| Err(e) if e.kind() == io::ErrorKind::NotFound => match parent_fd.mkdir_at(name, mode) { |
Contributor
Author
There was a problem hiding this comment.
done, added comments on the create and retry arms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12355.
Concurrent
install -Dinvocations sharing parent directories race inopen_or_create_subdir: betweenstat_atreturning NotFound andmkdir_at, another process can create the directory, so ourmkdir_atreturns EEXIST. Retry the stat to open the directory the other process created.#11505 also edits this function for a different concern (symlink-following per #11469); the two changes touch separate branches and rebase cleanly either way.