You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This updates the copy path to compare the opened source file metadata with the destination instead of canonicalizing the source path. That keeps openable special paths such as /dev/fd/0 working when the destination already exists while preserving same-file detection.
Tests:
cargo fmt --check
cargo test --features install --no-default-features test_install::test_install_from_stdin -- --nocapture
cargo test --features install --no-default-features test_install:: -- --nocapture
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
No successful run was found on main (d41c56b) during the generation of this report, so 3af25ae was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
I checked the new red CI on this PR. The diff only touches install code/tests (src/uu/install/src/install.rs, tests/by-util/test_install.rs, and tests/by-util/test_mkfifo.rs). The current failures are in unrelated targets: fuzz jobs for date, dirname, echo, non_utf8_paths, parse_time, and split, plus test_stdbuf_no_fork_regression.\n\nThe fuzz_date failure also matches the open upstream issue #12458. I do not see a PR-scoped code change to make for these failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12407.
This updates the copy path to compare the opened source file metadata with the destination instead of canonicalizing the source path. That keeps openable special paths such as
/dev/fd/0working when the destination already exists while preserving same-file detection.Tests:
cargo fmt --checkcargo test --features install --no-default-features test_install::test_install_from_stdin -- --nocapturecargo test --features install --no-default-features test_install:: -- --nocapturecargo test -p uu_installcargo clippy --features install --no-default-features --all-targets -- -D warnings