Skip to content

fix: prevent crash from force unwrap in UTMRegistry and memory leak in UTMAppleVirtualMachine #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caseydapro2020 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

fix: prevent crash from force unwrap in UTMRegistry and memory leak in UTMAppleVirtualMachine #7701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b34ce
fix: prevent crash from force unwrap in UTMRegistry
May 5, 2026
b2f4ae3
fix: memory leak in UTMAppleVirtualMachine when installation fails
May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Services/UTMAppleVirtualMachine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,8 @@ final class UTMAppleVirtualMachine: UTMVirtualMachine {
throw UTMAppleVirtualMachineError.operatingSystemInstallNotSupported
#endif
} catch {
progressObserver = nil
installProgress = nil
await stopAccesingResources()
delegate?.virtualMachine(self, didCompleteInstallation: false)
state = .stopped
Expand Down
8 changes: 4 additions & 4 deletions Services/UTMRegistry.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ class UTMRegistry: NSObject {
@Published private var entries: [String: UTMRegistryEntry] {
didSet {
let toAdd = entries.keys.filter({ !changeListeners.keys.contains($0) })
for key in toAdd {
let entry = entries[key]!
.compactMap { entries[$0] }
for entry in toAdd {
let key = entry.uuid.uuidString
changeListeners[key] = entry.objectWillChange
.debounce(for: .seconds(1), scheduler: DispatchQueue.global(qos: .utility))
.sink { [weak self, weak entry] in
Expand Down Expand Up @@ -122,8 +123,7 @@ class UTMRegistry: NSObject {
/// - Parameter entries: All entries to commit
private func commitAll(entries: [String: UTMRegistryEntry]) {
var newSerializedEntries: [String: Any] = [:]
for key in entries.keys {
let entry = entries[key]!
for entry in entries.values {
commit(entry: entry, to: &newSerializedEntries)
}
serializedEntries = newSerializedEntries
Expand Down