fix: skip Unix permission test on Windows (#648)#652
Open
Stark-SK wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR skips a Unix-specific config loader test on native Windows. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix: skip Unix permission test on Window..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skips
test_persist_current_sets_0600_modeon Windows because Unix file permissions (0o600) are not supported on Windows.Problem
On Windows,
target.stat().st_mode & 0o777returns33206(regular file), causing the assertion== 0o600to fail. This blocks Windows contributors from running the test suite cleanly.Fix
Added
@pytest.mark.skipif(os.name == 'nt', ...)decorator to skip this test on Windows.Testing
uv run pytest tests/test_config_loader.py::test_persist_current_sets_0600_mode -v->SKIPPEDon Windowsmake check-all(ruff, mypy, pre-commit) passesFixes #648