vere: refcount fixes - #1080
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains refcount fixes found in #1059 separately, so that #1059 only contains only refcount annotations.
Depends on #1079
List of fixes:
by_all/by_anyjets slammed the gate while keeping uncounted references tol_aandr_askid/skim/skipheld uncounted reference toiduring slam.ames.cmissingu3zin some brancheshttp.cmissingu3zin some branches, callbacks retained instead of transferring, which seems to be the protocol for callbacksterm.c: leak fixes (_reck_orchidretains), direct atom assertionunix.cdirect atom assertionsdawn.cu3r_string retains, u3nc transfers (although not a big deal right now as dawn_fail is noreturn)king.chelpers transferlord.cmissing break in switch!mars.cjarleakpier.ctagis transferred (probably left from u3r_string transferring long time ago)