forked from hawkerm/monaco-editor-uwp
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Desktop Skia support, STJ migration, and CI modernization #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
clairernovotny
wants to merge
323
commits into
main
Choose a base branch
from
dev/cnov/desktop-head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 250 commits
Commits
Show all changes
323 commits
Select commit
Hold shift + click to select a range
829b25d
chore(flow): mark fn-1.7 as done
clairernovotny eb599e4
fix(flow): sync task JSON metadata status for fn-1.7 and fn-1.8
clairernovotny 9e4c010
fix: address completion review gaps
clairernovotny 92f44ce
test(desktop): add markers, keyboard, and language service integratio…
clairernovotny 5ba294a
test(desktop): verify language service output and add multi-instance …
clairernovotny c4a160a
docs(spec): document Linux desktop validation as known gap
clairernovotny 4bc5c76
feat(serialization): add MonacoJsonContext and STJ contract tests
clairernovotny 08f62e0
fix: address review feedback for serialization context
clairernovotny 9bdad99
feat(serialization): migrate string enums to JsonStringEnumMemberName
clairernovotny 0fd9b04
fix(serialization): add Newtonsoft dual-stack compat for string enums
clairernovotny 1fc5fc6
feat(config): add scouts configuration for GitHub integration
clairernovotny efa1bcd
feat(serialization): rewrite domain converters for STJ
clairernovotny e183041
fix: address review feedback for domain converters
clairernovotny 23625ce
feat(serialization): migrate Monaco model JsonProperty attributes to STJ
clairernovotny 9b6e9b8
fix: address review feedback for STJ model migration
clairernovotny b6c0e80
chore: mark fn-2.3 done with review receipt
clairernovotny d35f8ba
fix: remove redundant JsonPropertyName on IMarkdownString.Uris
clairernovotny 3c782eb
feat(serialization): migrate call sites to STJ and redesign ParentAcc…
clairernovotny e434648
fix: address review feedback for STJ call-site migration
clairernovotny 0a1950a
chore: mark fn-2.5 done with review receipt
clairernovotny bf2b2ec
fix: address review feedback for AOT interface serialization and argu…
clairernovotny de39c19
fix: address review feedback for STJ call-site migration
clairernovotny 11bd47a
chore: mark fn-2.5 done with review receipt
clairernovotny 7a421c5
fix: remove double desanitization in WASM SetValue path
clairernovotny 2930aec
feat!: remove Newtonsoft.Json dependency from MonacoEditorComponent
clairernovotny 00e0068
fix: update stale test doc comment after Newtonsoft removal
clairernovotny 19c78a7
feat(generator): modernize type generation pipeline for STJ output
clairernovotny d5099a1
fix: address review feedback for typegen pipeline
clairernovotny b6ac171
chore: mark fn-2.7 done with evidence
clairernovotny ede480b
fix: remove remaining Newtonsoft word references from library and tests
clairernovotny 439bd3d
fix(serialization): register IMarkerData in MonacoJsonContext for AOT
clairernovotny d656283
fix: add IMarkerData round-trip test and remove legacy JSON word from…
clairernovotny 94ea3d8
fix(ci): disable Resizetizer splash screen and add linguist-generated…
clairernovotny 6f026e1
fix(ci): disable Uno.Resizetizer splash screen generation to resolve …
clairernovotny 43cb624
fix: add linguist-generated=false overrides for hand-tuned files
clairernovotny eadd0d3
ci: add macOS ARM CI job and clean up CI workflow
clairernovotny 3106039
fix: update BRANCH_MODE to 'current' in config.env and add scouts con…
clairernovotny 2e77127
feat(ci): Modernize CI, add code coverage, and replace broken type ge…
clairernovotny ebda4ae
chore(flow): update task specs for fn-3.1 completion and plan-sync
clairernovotny 3762344
fix(ci): add npm install and esbuild step to all CI jobs
clairernovotny 12ad13a
fix(ci): override Resizetizer GenerateUnoSplashWasm target to fix CI
clairernovotny 1327326
fix(ci): commit AppManifest.js and split CI build steps
clairernovotny e6bad77
fix(ci): fix Playwright browser install on CI runners
clairernovotny 0963c7a
fix(ci): use --project flag for dotnet test (.NET 10 requirement)
clairernovotny 9f2cf8c
fix(ci): set PLAYWRIGHT_DRIVER_SEARCH_PATH for test runtime driver re…
clairernovotny f3a991e
fix(tests): inline Playwright creation into fixtures for xUnit v3 compat
clairernovotny 3aa08f7
fix(ci): install wasm-tools workload in desktop-tests job
clairernovotny 1efcf53
ci: mark desktop-tests job as continue-on-error
clairernovotny 9d1bd4b
ci: fix desktop-tests job to report green on headless CI
clairernovotny 88c2d21
chore(flow): update task fn-3.4 spec with done summary and evidence
clairernovotny 5bf6bf9
ci: remove wasm-tools workload from desktop-tests job
clairernovotny 010b749
ci: update runner images, action versions, and SDK targets
clairernovotny 1471f00
chore(flow): update task fn-4.1 spec with done summary and evidence
clairernovotny ac1392f
chore: delete stale build/ directory and modernize README
clairernovotny 9d6cf60
chore(flow): update task fn-4.2 spec with done summary and evidence
clairernovotny 5371fa4
ci(coverage): add code coverage collection and merged reporting
clairernovotny 39fe436
chore(flow): update task fn-4.3 spec with done summary and evidence
clairernovotny 323d8ee
feat(tools): add ts-morph Monaco type extractor
clairernovotny d65fc2b
fix(tools): address review feedback for type extractor
clairernovotny 45db184
feat(tools): add .NET CLI tool for C# type emission from intermediate…
clairernovotny ea12f0f
fix(tools): address review feedback for type emitter
clairernovotny b08aea2
fix(tools): address second review feedback for type emitter
clairernovotny 67fe97b
fix(tools): address third review feedback for type emitter
clairernovotny 10fc88b
fix(tools): address fourth review feedback for type emitter
clairernovotny 5f90288
chore(flow): finalize fn-5 doc epic after plan review
clairernovotny ee8d1c5
fix(tools): address fifth review feedback for type emitter
clairernovotny c6aacc1
chore(flow): update task fn-4.5 spec with done summary and evidence
clairernovotny 695be92
test(tools): add generator pipeline tests for MonacoTypeEmitter
clairernovotny 320e72c
fix(tools): address review feedback for type emitter tests
clairernovotny cfd1951
fix(tools): address second review round for type emitter tests
clairernovotny 7d2be84
fix(tools): address third review round for type emitter tests
clairernovotny 861ac4b
chore(flow): update task fn-4.6 spec with done summary and evidence
clairernovotny b8ddf11
fix(tools): address fourth review feedback for type emitter tests
clairernovotny fe065d4
fix(tools): address fifth review feedback for type emitter tests
clairernovotny e2fe5cc
chore: migrate off GenerateMonacoTypings and clean up
clairernovotny 914cf8d
chore(flow): update task fn-4.7 spec with done summary and evidence
clairernovotny 99ff9c5
fix(wasm): replace LayoutUpdated resize handler with ResizeObserver
clairernovotny 49614d4
docs: add PR reviewer guide for refactoring branch
clairernovotny 986c291
fix(docs): address review feedback for PR reviewer guide
clairernovotny ea4d754
fix(docs): re-scope fn-3/fn-4 sections and add release-gate checklist
clairernovotny 6327d69
chore(flow): add done summary and evidence to fn-5.1 task spec
clairernovotny 3766cd6
chore(flow): update task fn-5.1 JSON metadata to done
clairernovotny 1f2a2cd
fix(flow): persist task fn-5.1 JSON status field
clairernovotny 2888375
docs(changelog): rewrite to Keep a Changelog format with breaking cha…
clairernovotny 2f5ea80
fix(docs): address review feedback for changelog
clairernovotny f1af4c5
fix(docs): remove mismatched comparison links for untagged versions
clairernovotny 6dfb4f4
chore(flow): add done summary and evidence to fn-5-comprehensive-docu…
clairernovotny 02223b4
chore(flow): update task fn-5-comprehensive-documentation-overhaul.2 …
clairernovotny d39166d
chore(flow): persist task fn-5-comprehensive-documentation-overhaul.2…
clairernovotny afb54dd
docs(architecture): add architecture design docs with Mermaid diagrams
clairernovotny 8effa56
fix(docs): address review feedback for architecture docs
clairernovotny ddc9336
chore(flow): add done summary and evidence sections to fn-5.3 task spec
clairernovotny dfd909a
chore(flow): fix evidence section header in fn-5.3 task spec
clairernovotny 80b6d2a
chore(flow): add done summary and evidence to fn-5-comprehensive-docu…
clairernovotny 3597fda
chore(flow): update task fn-5-comprehensive-documentation-overhaul.3 …
clairernovotny 53b2c9c
feat(ci): implement CI verification policy and fix test runner crash
clairernovotny bf53dfd
fix(test): resolve TypeLoadException by removing redundant Microsoft.…
clairernovotny 0f5d875
chore(flow): update task metadata for fn-7.1 completion
clairernovotny ccd362f
docs(agents): add CI verification policy to AGENTS.md
clairernovotny 13f9ac9
chore(flow): update task metadata for fn-7.2 completion
clairernovotny a6a5697
fix(ci): ensure test artifacts are uploaded regardless of test failures
clairernovotny ac9389b
fix(ci): exclude WasmPlaywright tests from macOS ARM and fix task met…
clairernovotny 8bdd33d
fix(ci): add cobertura output format for coverage reports
clairernovotny e04aff7
chore(flow): record CI pass evidence in fn-7 task specs
clairernovotny 3080fb9
docs: rewrite README with NuGet standard structure and platform matrix
clairernovotny fb24cfd
fix(ci): correct test result upload paths to use runner.temp
clairernovotny 9b18e5c
chore(flow): update fn-8.1 task spec with done summary and evidence
clairernovotny de1a312
chore(flow): align fn-5.4 spec with actual Uno SDK pack approach
clairernovotny 54fe703
chore(flow): update task metadata for fn-5.4 completion
clairernovotny 9e813c2
fix(build): auto-restore Monaco JS bundles on clean checkout
clairernovotny bd6d6c0
docs(api): add XML documentation to all hand-written public APIs
clairernovotny d98b84f
test(desktop): add regression tests for JsonRpc target registration o…
clairernovotny 5915256
fix(desktop): use standard EventHandler<T> for ThemeChanged event
clairernovotny 2c1a9d6
test(desktop): verify bridge target types are StreamJsonRpc-compatible
clairernovotny c5e8d1a
fix(desktop): add content serving and navigation to editor.html
clairernovotny 2fdc2bf
ci: enable DesktopCDP integration tests on Windows runner
clairernovotny 6a57552
fix(docs): narrow CS1591 suppression and document LanguagesHelper.Add…
clairernovotny ba83056
fix(desktop): use Uno cross-platform virtual host mapping for content…
clairernovotny f2baefa
chore(flow): update task metadata for fn-5.5 completion
clairernovotny ad096d6
chore(flow): sync downstream task specs after fn-5.5 XML docs impleme…
clairernovotny 1bc1f83
fix(docs): address review feedback on XML documentation
clairernovotny 2d13329
chore(flow): update fn-5.5 task metadata with review fix evidence
clairernovotny 9da971b
fix(desktop): detect missing WebKitGTK and use WebView2 control-level…
clairernovotny e3b76d7
docs: define XML documentation strategy for generated Monaco types
clairernovotny e12278b
fix(docs): address review feedback on generated type docs strategy
clairernovotny b545bc8
chore(flow): update fn-5.6 task metadata with completion evidence
clairernovotny 3549e1f
docs: add getting started guide and API cookbook
clairernovotny a66957a
fix(docs): address review feedback on getting started and cookbook
clairernovotny 663206e
chore(flow): update fn-5.7 task metadata with completion evidence
clairernovotny f049609
chore(flow): update fn-5.9 task metadata with plan-sync from fn-5.7
clairernovotny 477f388
fix(docs): correct recipe count from 12 to 15 in getting started guide
clairernovotny 2c76f72
fix(docs): use EditorLoaded for provider registration and remove inco…
clairernovotny 3ef5bbc
fix(docs): rename Editor_Loading handlers to Editor_Loaded in cookboo…
clairernovotny d87ca59
chore(flow): add EditorLoaded pitfall memory entry
clairernovotny eabeb5c
feat(emitter): add rich XML documentation to generated Monaco types
clairernovotny 8d522af
ci: exclude DesktopCDP tests from Windows CI runner
clairernovotny 6e7fee0
revert(generated): restore pre-regeneration Monaco type files
clairernovotny ad3b46b
fix(emitter): use neutral boolean return description in XML docs
clairernovotny 373f0a3
chore(flow): mark fn-5.8 task as done with evidence
clairernovotny 6c36396
chore(flow): update fn-5.9 task metadata with plan-sync from fn-5.8
clairernovotny 2491fa7
docs: fix broken Monaco API URLs across docs and source
clairernovotny 5fc6f7d
docs: document emitter TypeDoc URL pattern drift and add TODO
clairernovotny 9402fa6
feat(emitter): fix edge cases for exotic TS identifiers, regenerate t…
clairernovotny 5f65817
feat(emitter): fix edge cases for exotic TS identifiers
clairernovotny b83c57f
chore(flow): update task metadata after fn-10.1 completion
clairernovotny 06c6d70
fix(emitter): address review feedback for exotic identifier handling
clairernovotny c2ebe7e
fix(emitter): sanitize parameter names for valid C# identifiers
clairernovotny b51e540
feat(emitter): unify method invocation for desktop and WASM, remove p…
clairernovotny e96a327
feat(emitter): add XML docs, partial keyword, and CS1591 enforcement …
clairernovotny 2b0f719
fix(emitter): address review feedback for update-only file counting a…
clairernovotny d228a91
chore(flow): align epic spec partial keyword wording with C# constraint
clairernovotny 02ad0e2
ci(desktop-cdp): enable Desktop CDP tests on Windows CI runner
clairernovotny 18a3bfa
chore(flow): update fn-10.3 task metadata with done status and evidence
clairernovotny b6bda6c
feat(launch): add WSL2 desktop launch profile with display env vars
clairernovotny b2044ec
chore(flow): update fn-10.4 task metadata with done status and evidence
clairernovotny 064c81b
feat(editor): enable AddActionAsync/AddCommandAsync on desktop
clairernovotny 2079123
fix(editor): address review issues for desktop action/command support
clairernovotny 2f48e76
chore(flow): update fn-10.6 task metadata with done status and evidence
clairernovotny 9415dc8
fix(ci): prevent desktop test hang and add job timeout
clairernovotny aeaa671
fix(test): rewrite DesktopCDP tests to use public Monaco APIs and fix…
clairernovotny 5bd6e0c
fix(test): simplify DesktopCDP language tests and fix fixture disposa…
clairernovotny 30cc44b
Update Playwright to xunit.v3 package; reorder target frameworks
clairernovotny a6a0283
fix(test): restore Playwright build asset exclusion for UseArtifactsO…
clairernovotny 8e100c2
Update SDK rollForward to latestFeature in global.json
clairernovotny 3ed2abd
fix(test): revert to Microsoft.Playwright to fix CI fixture disposal …
clairernovotny 023b76e
feat(tests): enhance Desktop CDP integration with Playwright package …
clairernovotny c264919
fix(ci): update completion review timestamps and statuses in emitter …
clairernovotny bc4d89e
fix(test): replace Microsoft.Playwright with Xunit.v3 adapter and sta…
clairernovotny 4dd9eef
feat(tests): add comprehensive C# bridge integration tests for Deskto…
clairernovotny 61258e7
fix(ci): address review feedback - standardize ARTIFACTS_PATH and sim…
clairernovotny 3cdd367
fix(ci): extract Playwright install to composite action with pinned v…
clairernovotny 11e6142
chore(flow): update fn-10.7 done summary with review fix commits and …
clairernovotny 8c993fa
feat(bridge): fix desktop bridge initialization bugs and lifecycle fl…
clairernovotny c02a52a
fix(bridge): clear _unloadCts after hard teardown and synchronize log…
clairernovotny bf2724c
fix(test): update stale comment about SecondaryTarget dispatch style
clairernovotny 31fa9a4
chore(flow): add pitfall memory entries for review fixes
clairernovotny 3601cec
feat(test): add comprehensive C# bridge integration tests via Desktop…
clairernovotny 754e8da
fix(test): address review feedback for bridge integration tests
clairernovotny 048ffc0
fix(test): address review issues in bridge integration tests
clairernovotny 8b45571
fix(test): make bridge tests order-independent and strengthen assertions
clairernovotny ff33d70
fix(test): ensure all tests reset state and fix double-encoded bridge…
clairernovotny f288081
fix(test): gate tests on harness readiness, add DOM glyph verificatio…
clairernovotny e5075c5
fix(test): drive markers/decorations through C# actions and verify Mo…
clairernovotny 95be6f4
chore(flow): update fn-10.9 task spec with done summary and evidence
clairernovotny bc26df6
fix(ci): copy Playwright DLL to build/ for browser install script
clairernovotny e93e627
fix(ci): invoke Playwright CLI directly from NuGet cache with correct…
clairernovotny 01c7168
fix(editor): add diagnostic logging to NavigationCompleted for CI deb…
clairernovotny dff626f
fix(bridge): marshal PostWebMessage and GetJsonValue to UI thread
clairernovotny 9db87b9
fix(bridge): add diagnostic logging to JSON-RPC message flow for CI d…
clairernovotny 5c9351f
fix(bridge): add reflection fallback for unregistered framework types…
clairernovotny 7ce9f1a
fix(bridge): add error recovery to Monaco theme initialization for CI…
clairernovotny 5e1ef63
fix: update completion review status and timestamps for fn-10 epic; m…
clairernovotny 46be95e
feat: Implement epic fn-13 to fix desktop WebView2 runtime bugs
clairernovotny 60b6465
fix(lifecycle): retain desktop presenter across unload/load cycles
clairernovotny c22ffa8
fix(bridge): resolve JSON-RPC deadlock, ElementTheme serialization, a…
clairernovotny ab3d565
fix(editor): guard null/collapsed selection in updateSelectedContent …
clairernovotny 194de72
chore(flow): update task fn-13.3 status metadata
clairernovotny 2a69991
feat(fn-13): Implement fixes and enhancements for desktop WebView2 ru…
clairernovotny 4fd012b
feat(bridge): fix desktop init threading model, push initial state, e…
clairernovotny 598947d
chore(flow): sync downstream task specs after fn-13.6 implementation
clairernovotny 3bd593f
fix(desktop): harden editor init sequencing
clairernovotny 23ad575
fix(desktop): avoid async theme fallback rpc
clairernovotny 717cc48
fix(build): rebuild bundles when ts changes
clairernovotny 5249d48
fix(desktop): preserve presenter on tab unload
clairernovotny 74d314b
fix(desktop): hide presenter until ready
clairernovotny 514a3a0
fix(desktop): collapse host until editor ready
clairernovotny e682b4c
fix(desktop): keep host visible during init
clairernovotny b2c9085
fix(desktop): prevent hidden-host init stalls
clairernovotny 3734372
fix(desktop): preserve presenter during launch
clairernovotny e8a23ee
fix(desktop): decode hover event args
clairernovotny 79e6ee5
fix(desktop): hide host on control unload
clairernovotny d396ea7
fix(desktop): reduce tab reload churn
clairernovotny 2f5c69e
fix(desktop): restore hidden launch visibility
clairernovotny b8fda10
fix(desktop): recover bootstrap after unload
clairernovotny 7706156
fix(desktop): stabilize visibility and hover providers
clairernovotny 73810d2
fix(desktop): unblock mac navigation and add recovery diagnostics
clairernovotny ee1e688
fix(desktop): rebootstrap after hard teardown
clairernovotny 6e7dd92
fix(desktop): add autonomous init self-check
clairernovotny 5939af7
fix(desktop): enhance initialization completion monitoring and JSON p…
clairernovotny 20ef8eb
fix(desktop): improve error handling for JavaScript execution by chec…
clairernovotny 10ab9af
fix(desktop): invoke EditorLoaded event when editor is loaded and boo…
clairernovotny 8276a73
fix(desktop): enhance JSON message handling and add feature probe for…
clairernovotny de73e1c
fix(desktop): improve JSON serialization for action descriptors and a…
clairernovotny d46018c
fix(desktop): enhance action registration and execution with paramete…
clairernovotny 7171fe5
fix(desktop): improve hover provider responsiveness and tooltip accuracy
clairernovotny d6c292e
fix(desktop): correct string comparison for hover word matching
clairernovotny 16d7b63
fix(desktop): update keybinding context and precondition for TestAction
clairernovotny 927ced1
fix(desktop): add presenter visibility checks and improve hover provi…
clairernovotny b479e17
fix(desktop): add visibility checks for host and improve layout handl…
clairernovotny 5c23257
fix(desktop): decode hover event args
clairernovotny fb16f35
fix(desktop): improve JSON serialization for action descriptors and a…
clairernovotny 54f9fc1
fix(desktop): enhance action registration and execution with paramete…
clairernovotny 9bc1c5d
fix(desktop): improve hover provider responsiveness and tooltip accuracy
clairernovotny ae54359
fix(desktop): correct string comparison for hover word matching
clairernovotny 45eaf09
fix(desktop): update keybinding context and precondition for TestAction
clairernovotny bb537ca
fix(desktop): add presenter visibility checks and improve hover provi…
clairernovotny b084bd8
fix(desktop): add visibility checks for host and improve layout handl…
clairernovotny 8113054
fix(desktop): restore load guard helpers
clairernovotny 73680ab
fix(desktop): enhance initialization completion monitoring and JSON p…
clairernovotny 12e48f5
fix(desktop): probe context on soft reload
clairernovotny a887de7
fix(desktop): keep subscriptions across tab unload
clairernovotny 1b15e95
fix(desktop): use fallback editor context probe
clairernovotny 9af402c
fix(desktop): keep host visible across tab detach
clairernovotny fabee66
fix(build): rebuild bundles when ts changes
clairernovotny 5b03b43
chore(merge): integrate upstream desktop fixes
clairernovotny 96752e2
fix(desktop): improve host visibility handling for desktop tab switches
clairernovotny fb9a06b
feat: Add HybridWebView control library and associated tasks
clairernovotny 70374f1
Remove ExcludeAssets from Playwright package reference
clairernovotny 1bd4521
fix(ci): correct SourceRoot and Playwright output
clairernovotny 1a101fc
fix(ci): patch DBus protocol dependency
clairernovotny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -13,7 +13,8 @@ end_of_line = crlf | |||||||||||
| dotnet_sort_system_directives_first = true | ||||||||||||
|
|
||||||||||||
| # CS1591: Missing XML comment for publicly visible type or member | ||||||||||||
| dotnet_diagnostic.CS1591.severity = none | ||||||||||||
| # Enabled as warning for hand-written code; suppressed in Monaco/ for generated types. | ||||||||||||
| dotnet_diagnostic.CS1591.severity = warning | ||||||||||||
|
|
||||||||||||
|
||||||||||||
| [MonacoEditorComponent/Monaco/**/*.cs] | |
| # Generated Monaco types: suppress CS1591 to avoid requiring XML docs on generated code | |
| dotnet_diagnostic.CS1591.severity = none |
343 changes: 343 additions & 0 deletions
343
.flow/.checkpoint-fn-1-implement-desktop-skia-target-for.json
Large diffs are not rendered by default.
Oops, something went wrong.
371 changes: 371 additions & 0 deletions
371
.flow/.checkpoint-fn-10-fix-reverted-emitter-docs-enable-cdp-ci.json
Large diffs are not rendered by default.
Oops, something went wrong.
179 changes: 179 additions & 0 deletions
179
.flow/.checkpoint-fn-11-extract-emitter-as-general-purpose-dts.json
Large diffs are not rendered by default.
Oops, something went wrong.
149 changes: 149 additions & 0 deletions
149
.flow/.checkpoint-fn-13-fix-desktop-webview2-runtime-bugs.json
Large diffs are not rendered by default.
Oops, something went wrong.
299 changes: 299 additions & 0 deletions
299
.flow/.checkpoint-fn-2-type-generation-pipeline-and.json
Large diffs are not rendered by default.
Oops, something went wrong.
180 changes: 180 additions & 0 deletions
180
.flow/.checkpoint-fn-3-merge-ralph-branch-add-macos-arm-ci-and.json
Large diffs are not rendered by default.
Oops, something went wrong.
315 changes: 315 additions & 0 deletions
315
.flow/.checkpoint-fn-4-modernize-ci-add-code-coverage-and.json
Large diffs are not rendered by default.
Oops, something went wrong.
170 changes: 170 additions & 0 deletions
170
.flow/.checkpoint-fn-5-comprehensive-documentation-overhaul.json
Large diffs are not rendered by default.
Oops, something went wrong.
151 changes: 151 additions & 0 deletions
151
.flow/.checkpoint-fn-6-bug-fixes-disposal-resize-and-test.json
Large diffs are not rendered by default.
Oops, something went wrong.
98 changes: 98 additions & 0 deletions
98
.flow/.checkpoint-fn-7-fix-ci-test-runner-crash-and-add-ci.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/bash | ||
| # flowctl wrapper - invokes flowctl.py from the same directory | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| exec python3 "$SCRIPT_DIR/flowctl.py" "$@" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment states 'suppressed in Monaco/ for generated types' but no suppression rule is shown. The Monaco/.editorconfig file (line 12) has
dotnet_diagnostic.CS1591.severity = none. Clarify in this comment that suppression is configured in MonacoEditorComponent/Monaco/.editorconfig, not here, to avoid confusion about where the suppression actually occurs.