forked from DSpace/dspace-angular
-
Notifications
You must be signed in to change notification settings - Fork 10
169 author name firstname lastname spacing on details page #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amadulhaxxani
wants to merge
4
commits into
clarin-v7
Choose a base branch
from
169-author-name-firstname-lastname-spacing-on-details-page
base: clarin-v7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
814527b
feat(author): add FormatAuthorPipe for display with space after comma
amadulhaxxani 512dabf
test(author): add unit tests for FormatAuthorPipe
amadulhaxxani f1597a4
fix(author): store author with comma-space and fix display pipe edge …
amadulhaxxani 2ec8554
fix(test): update separator expectation in clarin-name parser spec
amadulhaxxani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { FormatAuthorPipe } from "./format-author.pipe"; | ||
|
Check failure on line 1 in src/app/shared/utils/format-author.pipe.spec.ts
|
||
|
Copilot marked this conversation as resolved.
Outdated
|
||
|
|
||
| describe('FormatAuthorPipe', () => { | ||
| let pipe: FormatAuthorPipe; | ||
|
|
||
| beforeEach(() => { | ||
| pipe = new FormatAuthorPipe(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(pipe).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should add single space after comma when missing', () => { | ||
| expect(pipe.transform('Doe,John')).toEqual('Doe, John'); | ||
| }); | ||
|
|
||
| it('should keep single space after comma unchanged', () => { | ||
| expect(pipe.transform('Doe, John')).toEqual('Doe, John'); | ||
| }); | ||
|
|
||
| it('should return value as-is when there is no comma', () => { | ||
| expect(pipe.transform('')).toEqual(''); | ||
| expect(pipe.transform(null as any)).toBeNull(); | ||
| expect(pipe.transform('John Doe')).toEqual('John Doe'); | ||
| expect(pipe.transform(undefined as any)).toBeUndefined(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { Pipe, PipeTransform } from '@angular/core'; | ||
|
|
||
| @Pipe({ name: 'dsFormatAuthor' }) | ||
| export class FormatAuthorPipe implements PipeTransform { | ||
| transform(value: string): string { | ||
| // Normalise comma followed by zero or more whitespace to a single comma + space | ||
| return value?.replace(/,\s*/g, ', ') || value; | ||
| } | ||
|
amadulhaxxani marked this conversation as resolved.
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.