Skip to content

Issue #1346 incorrect xml response from signposting api #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuchtiak-ufal wants to merge 3 commits into
base: clarin-v7
Choose a base branch
from
Open

Issue #1346 incorrect xml response from signposting api #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81cb914
Issue 1346: signposting/describedby endpoint returns incorrect XML file
kuchtiak-ufal Mar 19, 2026
13ec373
test added
kuchtiak-ufal Mar 19, 2026
ca4ae61
resolve Copilot comment
kuchtiak-ufal Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ebapp/src/main/java/org/dspace/app/rest/signposting/controller/LinksetRestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,10 @@ public String getDescribedBy(
DSpaceObject object = findObject(context, uuid);
DisseminationCrosswalk xwalk = (DisseminationCrosswalk)
pluginService.getNamedPlugin(DisseminationCrosswalk.class, xwalkName);
List<Element> elements = xwalk.disseminateList(context, object);
// Output valid XML: disseminate using root element as opposed to list
Element element = xwalk.disseminateElement(context, object);
XMLOutputter outputter = new XMLOutputter(Format.getCompactFormat());
return outputter.outputString(elements);
return outputter.outputString(element);
}

private DSpaceObject findObject(Context context, UUID uuid) {
Expand Down
2 changes: 2 additions & 0 deletions ...app/src/test/java/org/dspace/app/rest/signposting/controller/LinksetRestControllerIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,8 @@ public void getDescribedBy() throws Exception {

getClient().perform(get("/signposting/describedby/" + item.getID()))
.andExpect(status().isOk())
.andExpect(content().string(
Matchers.startsWith("<resource xmlns=\"http://datacite.org/schema/kernel-4\"")))
.andExpect(content().string(Matchers.containsString(title)))
.andExpect(header().stringValues("Content-Type", responseMimeType + ";charset=UTF-8"));
}
Expand Down
Loading