Skip to content

PR 3: chore(quality): mechanical analyzer-driven cleanup (453 files) #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlorenzo merged 10 commits into from
May 21, 2026

fix(quality): pass TestContext.Current.CancellationToken on touched l…

282bb6d
Select commit
Loading
Failed to load commit list.
Merged

PR 3: chore(quality): mechanical analyzer-driven cleanup (453 files) #176

fix(quality): pass TestContext.Current.CancellationToken on touched l…
282bb6d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded May 14, 2026 in 2s

30 new alerts

New alerts in code changed by this pull request

  • 12 warnings
  • 18 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 230 in test/ClinicalScheduler/ClinicalSchedulerTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 242 in test/ClinicalScheduler/ClinicalSchedulerTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 133 in test/ClinicalScheduler/IntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 241 in test/ClinicalScheduler/IntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 342 in test/Effort/EffortIntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 352 in test/Effort/EffortIntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 182 in test/RAPS/RolesTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
TblRole
Loading
- the conversion can be done implicitly.

Check warning on line 125 in test/Services/EmailServiceTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 211 in test/Services/EmailServiceTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 67 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 242 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 453 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check notice on line 240 in web/Areas/CTS/Controllers/CourseController.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check notice on line 286 in web/Areas/CTS/Controllers/CourseController.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check notice on line 33 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 81 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 448 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 479 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 490 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 531 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 577 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 225 in web/Services/EmailService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 251 in web/Services/EmailService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 275 in web/Services/EmailService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 151 in web/Services/HtmlToTextConverter.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.