-
Notifications
You must be signed in to change notification settings - Fork 857
Add post-fit confidence intervals to BaseTLearner via store_bootstraps and return_ci
#886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aman-coder03
wants to merge
8
commits into
uber:master
Choose a base branch
from
aman-coder03:feature/predict-return-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f6c186
add store_bootstraps to fit() and return_ci to predict() in BaseTLearner
aman-coder03 39c4f50
style: black formatting on tlearner.py
aman-coder03 c78d9a1
formatting on test_meta_learners.py
aman-coder03 cc000d0
address review feedback
aman-coder03 f258cdb
use control_name=0 to match generate_regression_data
aman-coder03 8cd568b
use clone, joblib, warning on degenerate samples, n_bootstraps=200
aman-coder03 c0f704b
move bootstrap ensemble logic to BaseLearner
aman-coder03 470b2aa
fit_bootstrap_ensemble clones full learner, following EconML Bootstra…
aman-coder03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This routine is T-learner specific. The bootstrap logic in BaseLearner should be applicable across all meta-learners. Check EconML's BootstrapEstimator for a reference.