-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add bowties and deprecate join
#93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
50ba089
2b76536
847cdcd
9d925da
c2e455d
90e94e8
64120c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -697,10 +697,20 @@ diameter ⌀ | |
| interleave ⫴ | ||
| .big ⫼ | ||
| .struck ⫵ | ||
| @deprecated: `join` is deprecated, use `bowtie.big` instead | ||
| join ⨝ | ||
| .r ⟖ | ||
| .l ⟕ | ||
| .l.r ⟗ | ||
| bowtie | ||
| .stroked ⋈ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it makes more sense to just put this at the top level (without stroked), unless there are additional variants not included here.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's what I had originally, but my thinking was that it makes more sense to keep
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently we aren't entirely consistent (which we ideally should improve upon), but in my mind it makes more sense when there is no canonical variant. In this case the stroked one is the canonical variant, and Not to mention the big variants are variants of the stroked ones.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remember that it's not required. Since
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I know that it's not required, but I don't think that's a good reason to add unnecessary modifiers.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Notice how the unicode names mention "black" specifically, but not "white" for the regular ones.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I really don't want the added complexity of enshrining a "canonical version" for some symbols by means of omitting certain modifiers for them. That's another data point users will have to remember and seems like a totally unnecessary restriction. It's conceptually so much simpler to just have both modifiers for everything with those two styles, whether one of them is canonical or not.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say that having .stroked is
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
But fallback is a feature. If you choose not to use it, then of course you may have to specify annoying modifiers. My view is that most changes do not affect fallbacks. When they do, we should be careful about it. And we should have a way to specify which fallbacks can be relied on, and which cannot (e.g., with the minimal modifier set proposal I link everywhere).
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree having some symbols with "canonical version" and some without is annoying.
Beyond the fact that you don't have to know that (thanks fallbacks), I like that I can know there's a 'stroked' if there's a 'filled' and vice versa. So I think having |
||
| .stroked.big ⨝ | ||
| .stroked.big.l ⟕ | ||
| .stroked.big.r ⟖ | ||
| .stroked.big.l.r ⟗ | ||
| .filled ⧓ | ||
| .filled.l ⧑ | ||
| .filled.r ⧒ | ||
| hourglass | ||
| .stroked ⧖ | ||
| .filled ⧗ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.