Remove dead shadow_pict field from win struct - #51
Open
jEsuSdA wants to merge 1 commit into
Open
Conversation
The shadow_pict field in the win struct was set to None on creation and never used anywhere in the codebase. Removing it shrinks the struct by one Picture pointer (8 bytes on 64-bit) with no functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
shadow_pictfield from thewinstruct, shrinking it by one pointer with no functional change.Problem
The
shadow_pictfield in thewinstruct is set toNoneon creation and never used anywhere in the codebase. It is a leftover from earlier development that serves no purpose.Solution
Remove the field and all assignments/frees associated with it.
Scope
cm-window.h— removesPicture shadow_pictfieldfastcompmgr.c— removes three references (init inadd_win, free indetermine_mode, free infinish_destroy_win)make clean && makeproduces zero warnings, zero errorsImpact
Shrinks the
winstruct by 8 bytes on 64-bit platforms. No functional change.