Cache root background atoms to avoid repeated XInternAtom calls - #44
Open
jEsuSdA wants to merge 1 commit into
Open
Cache root background atoms to avoid repeated XInternAtom calls#44jEsuSdA wants to merge 1 commit into
jEsuSdA wants to merge 1 commit into
Conversation
root_create_tile() calls XInternAtom() for each root background property every time it is invoked. Atoms are fixed X server-side identifiers that never change during a session, so this is an unnecessary round-trip. Cache the atoms once in a static array on first call and reuse them. This eliminates 1-2 XInternAtom() calls per root background paint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caches root background atoms (
_XROOTPMAP_ID,_XSETROOT_ID) on first use to eliminate repeatedXInternAtom()calls every time the root background is painted.Problem
root_create_tile()callsXInternAtom()for each root background property every time it is invoked. Atoms are fixed X server-side identifiers that never change during a session, so this is an unnecessary round-trip.Solution
Cache the atoms in a static array on first call to
root_create_tile()and reuse them on subsequent calls. A staticatoms_cachedflag ensures the cache is only populated once.Scope
cm-root.cis touchedmake clean && makeproduces zero warnings, zero errorsImpact
Eliminates 1–2
XInternAtom()calls per root background paint. Minor performance improvement, but trivial and correct.