Skip to content

Cache find_client_win results to avoid repeated XQueryTree scans #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jEsuSdA wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cache find_client_win results to avoid repeated XQueryTree scans #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cm-window.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ typedef struct _win {
unsigned long damage_sequence; /* sequence when damage was created */
Bool destroyed;
Bool paint_needed;
Bool client_id_resolved;
Window client_id;
unsigned int left_width;
unsigned int right_width;
unsigned int top_width;
Expand Down
19 changes: 17 additions & 2 deletions fastcompmgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,13 @@ get_frame_extents(win* w,
*top = 0;
*bottom = 0;

client_window = find_client_win(dpy, w->id);
if (w->client_id_resolved) {
client_window = w->client_id;
} else {
client_window = find_client_win(dpy, w->id);
w->client_id = client_window;
w->client_id_resolved = True;
}
if (!client_window) {
w->hidden_type = win_state_is_hidden( w->id) ? HIDDEN_YES : HIDDEN_NO;
return;
Expand Down Expand Up @@ -966,7 +972,14 @@ win_paint_needed(win* w, CompRect* ignore_reg){
case HIDDEN_UNKNOWN: {
fprintf(stderr, "fastcompmgr warning: hidden state still unknown in "
"win_paint_needed: 0x%lx\n", w->id);
Window client_window = find_client_win(dpy, w->id);
Window client_window;
if (w->client_id_resolved) {
client_window = w->client_id;
} else {
client_window = find_client_win(dpy, w->id);
w->client_id = client_window;
w->client_id_resolved = True;
}
if (!client_window) {
// We already tried to find a client on add_win - give up for now.
w->hidden_type = HIDDEN_IGNORE;
Expand Down Expand Up @@ -1253,6 +1266,8 @@ add_damage_if_hidden_changed(Window window, bool is_reparent_event) {
}
if(is_reparent_event){
win_register_client_events(window);
w->client_id = 0; // invalidate cached client, will be re-resolved
w->client_id_resolved = False;
}
hiddentype hidden_type = win_state_is_hidden(window) ? HIDDEN_YES : HIDDEN_NO;
// _NET_WM_STATE may change without altering _NET_WM_STATE_HIDDEN, so
Expand Down