Skip to content

chore: bump pallas to 0.35 for van Rossem compatibility#922

Merged
scarmuega merged 1 commit into
mainfrom
chore/pallas-0.35-van-rossem
May 5, 2026
Merged

chore: bump pallas to 0.35 for van Rossem compatibility#922
scarmuega merged 1 commit into
mainfrom
chore/pallas-0.35-van-rossem

Conversation

@scarmuega
Copy link
Copy Markdown
Member

@scarmuega scarmuega commented May 5, 2026

Summary

  • Bumps pallas from 0.33 to 0.35 so Oura advertises NodeToClient handshake versions v17–v23, which cardano-node 10.7 (the van Rossem hard fork target) negotiates.
  • No source changes needed: Oura connects through NodeClient::connect / PeerClient::connect, which use n2c::VersionTable::v10_and_above / n2n::VersionTable::v7_and_above. Pallas 0.35 widens those tables; the new versions flow through automatically.
  • Van Rossem is an intra-era hard fork inside Conway (PV11). Block CBOR shape, the Era enum in pallas-traverse, and MultiEraBlock are unchanged, so chain-sync / block-fetch decoding paths need no updates.

Why not pallas 1.0.0-alpha.x?

The 1.0.0-alpha line is a much larger refactor (introduces pallas-network2, splits out a p2p crate, reworks Conway phase-one validation). For a "compatibility" change, staying on the 0.x line keeps the diff to a one-line bump.

Test plan

  • cargo check --all-features passes (only pre-existing StreamStrategy dead-code warning).
  • cargo build --no-default-features passes.
  • cargo build --no-default-features --features "aws,sql,gcp,rabbitmq,zeromq,u5c,hydra,wasm" passes.
  • cargo test with the same feature set: 18/18 unit + 16/16 hydra integration tests pass.
  • Manual smoke test against a cardano-node 10.7 / van Rossem testnet socket (chain-sync + block-fetch).
  • Re-run on CI matrix; confirm the mithril feature builds (couldn't verify locally — pre-existing gmp-mpfr-sys x86_64/arm64 archive issue on the dev machine, unrelated to this bump; reproduces on main before the change).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal dependency to a newer version for improved compatibility and stability.

Pallas 0.33 advertised N2C handshake versions only up to v16; cardano-node
10.7 (van Rossem hard fork) negotiates up to v23. Pallas 0.35 widens the
v10_and_above version table accordingly.

Oura uses the high-level NodeClient/PeerClient facades, so no source
changes are needed — the new versions flow through automatically.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@scarmuega scarmuega requested a review from paulobressan as a code owner May 5, 2026 19:48
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 195bf115-4d2a-4606-9185-b484d59c04bc

📥 Commits

Reviewing files that changed from the base of the PR and between d5c6d6a and 0f14c99.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

A single dependency version bump: the pallas crate is updated from version 0.33 to 0.35 while retaining the hardano feature flag.

Changes

Dependency Update

Layer / File(s) Summary
Cargo.toml
Cargo.toml
pallas dependency version bumped from 0.33 to 0.35; hardano feature flag retained.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A nibble here, a version there,
Pallas grows with utmost care,
From thirty-three to thirty-five it springs,
The hardano magic still takes wing! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping the pallas dependency from 0.33 to 0.35 with specific context about van Rossem compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pallas-0.35-van-rossem

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit 91457f7 into main May 5, 2026
10 of 11 checks passed
@scarmuega scarmuega deleted the chore/pallas-0.35-van-rossem branch May 5, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant