chore: bump pallas to 0.35 for van Rossem compatibility#922
Conversation
Pallas 0.33 advertised N2C handshake versions only up to v16; cardano-node 10.7 (van Rossem hard fork) negotiates up to v23. Pallas 0.35 widens the v10_and_above version table accordingly. Oura uses the high-level NodeClient/PeerClient facades, so no source changes are needed — the new versions flow through automatically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single dependency version bump: the ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
pallasfrom0.33to0.35so Oura advertises NodeToClient handshake versions v17–v23, which cardano-node 10.7 (the van Rossem hard fork target) negotiates.NodeClient::connect/PeerClient::connect, which usen2c::VersionTable::v10_and_above/n2n::VersionTable::v7_and_above. Pallas 0.35 widens those tables; the new versions flow through automatically.Eraenum inpallas-traverse, andMultiEraBlockare unchanged, so chain-sync / block-fetch decoding paths need no updates.Why not pallas 1.0.0-alpha.x?
The
1.0.0-alphaline is a much larger refactor (introducespallas-network2, splits out ap2pcrate, reworks Conway phase-one validation). For a "compatibility" change, staying on the0.xline keeps the diff to a one-line bump.Test plan
cargo check --all-featurespasses (only pre-existingStreamStrategydead-code warning).cargo build --no-default-featurespasses.cargo build --no-default-features --features "aws,sql,gcp,rabbitmq,zeromq,u5c,hydra,wasm"passes.cargo testwith the same feature set: 18/18 unit + 16/16 hydra integration tests pass.mithrilfeature builds (couldn't verify locally — pre-existinggmp-mpfr-sysx86_64/arm64 archive issue on the dev machine, unrelated to this bump; reproduces onmainbefore the change).🤖 Generated with Claude Code
Summary by CodeRabbit