feat: stdlib logging to Logfire; Sentry for warning/error#129
Open
tomhamiltonstubber wants to merge 1 commit intomasterfrom
Open
feat: stdlib logging to Logfire; Sentry for warning/error#129tomhamiltonstubber wants to merge 1 commit intomasterfrom
tomhamiltonstubber wants to merge 1 commit intomasterfrom
Conversation
- Add LogfireLoggingHandler to chronos/uvicorn loggers when Logfire is configured - Use chronos logger for app_logger so worker logs respect dictConfig - Call setup_logging from Celery worker_process_init (workers never loaded main.py) - init_sentry with LoggingIntegration (events for WARNING+) and CeleryIntegration on workers Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the gap noted on PR #124: standard library
loggingwas not reaching the Logfire pipeline (especially Celery workers, which never importmain.pyand therefore never randictConfig).Changes
LOGFIRE_TOKENis set, addlogfire.LogfireLoggingHandlerto thechronosanduvicornloggers alongside the existing stream handlers.app_loggernow useschronosinstead ofbase, so it is covered by the same dict config (andchronos.dispatcherstill propagates to it).worker_process_init, callsetup_logging()after Sentry/Logfire setup so worker and dispatcher logs are configured in every forked worker process.init_sentry()usesLoggingIntegrationwithevent_level=WARNINGsologger.warning,logger.error, andlogger.exceptionproduce Sentry events. Celery workers also getCeleryIntegrationviainit_sentry(for_celery_worker=True).init_sentryruns before importingviews/workerso Sentry is ready before the app graph loads (RuffE402noqa on those imports).Testing
uv run ruff checkon touched files.Made with Cursor