[AMD] Re-enable true16 feature for gfx1100 - #11188
Draft
saeid-rostami wants to merge 1 commit into
Draft
Conversation
antiagainst
reviewed
Aug 6, 2026
|
|
||
| def disable_real_true16_feature(arch): | ||
| return '-real-true16' if arch.startswith('gfx11') else '' | ||
| return '-real-true16' if arch.startswith('gfx11') and arch != 'gfx1100' else '' |
Member
There was a problem hiding this comment.
Why gfx1100 specifically? Are all other gfx11* targets still having issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triton currently skips -real-true16 for gfx100 target because enabling true16 previously caused a severe compile-time regression in scaled FP4/FP8 dot kernels.
That issue was fixed by this PR on LLVM llvm/llvm-project#208136
Tested locally and I did not see any compile time issue on gfx100
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsit fixes a compile time issue on scaled do tests.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)