Skip to content

Preserve THP-BLE name cache across recovery#6020

Merged
mmilata merged 2 commits into
mainfrom
mmilata/recovery-name-cache
Oct 20, 2025
Merged

Preserve THP-BLE name cache across recovery#6020
mmilata merged 2 commits into
mainfrom
mmilata/recovery-name-cache

Conversation

@mmilata
Copy link
Copy Markdown
Member

@mmilata mmilata commented Oct 16, 2025

In these cases we're preserving device secret and BLE bonds thus we should preserve the names as well.

Includes 4f4f742 because it confused me for a bit.

cc @yanascz

@mmilata mmilata requested a review from obrusvit as a code owner October 16, 2025 14:12
@trezor-bot trezor-bot Bot added this to Firmware Oct 16, 2025
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Oct 16, 2025
@mmilata mmilata requested review from M1nd3r and romanz October 16, 2025 14:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 16, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 18648729782

Comment thread core/src/storage/device.py
Copy link
Copy Markdown
Contributor

@romanz romanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Maybe add a device test?

Copy link
Copy Markdown
Contributor

@M1nd3r M1nd3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mmilata mmilata self-assigned this Oct 17, 2025
@mmilata mmilata added core Trezor Core firmware. Runs on Trezor Model T and Safe models. T3W1 Trezor Safe 7 labels Oct 17, 2025
@mmilata mmilata mentioned this pull request Oct 20, 2025
2 tasks
@mmilata
Copy link
Copy Markdown
Member Author

mmilata commented Oct 20, 2025

Maybe add a device test?

I don't think it's currently possible to add BLE bonds from device tests. Should be possible after #4838. But yeah there should be a testcase, let's track it in #6041.

In the context of storage what we call cache does not persists across
reboots but this structure does.

[no changelog]
@mmilata mmilata force-pushed the mmilata/recovery-name-cache branch from 2215823 to a58f368 Compare October 20, 2025 10:06
@mmilata mmilata merged commit 3ea2dc4 into main Oct 20, 2025
105 checks passed
@mmilata mmilata deleted the mmilata/recovery-name-cache branch October 20, 2025 15:29
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Trezor Core firmware. Runs on Trezor Model T and Safe models. T3W1 Trezor Safe 7

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants