Skip to content

BLE: pairing flow & fixes#4916

Merged
mmilata merged 6 commits into
mainfrom
ble
Jun 5, 2025
Merged

BLE: pairing flow & fixes#4916
mmilata merged 6 commits into
mainfrom
ble

Conversation

@mmilata
Copy link
Copy Markdown
Member

@mmilata mmilata commented Apr 14, 2025 •
edited
Loading

Pairing flow for Eckhart UI and several loosely related fixes.

  • 4bc3076: Enables Eckhart UI to respond to BLE events.
  • 5f61e92: Adds BLE pairing flow initiated from the device menu.
  • e645c6a: Makes all layouts receive the BLE events, not just homescreen. While it's needed for the pairing flow I think it is desirable to remove events from the event queue even if they don't influence the UI shown. This way the queue always contains up-to-date state changes. Wonder if we should do this for USB state too ...
  • 4fe8699: Moves BLE startup to it's own file so that exceptions don't kill the entire firmware and the module gets properly unimported afterwards.
  • 2489471: Generalizes pairing code screen so that it is usable by THP. Provide T2T1 stand-in for testing.
  • 699f5bf: Makes it easier to write handlers that work both with and without context. Obsoletes Support workflow handlers that may or may not have context #4919.

@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 14, 2025
@mmilata mmilata mentioned this pull request Apr 14, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3W1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata force-pushed the ble branch 2 times, most recently from bc15789 to 7ca1d21 Compare April 24, 2025 22:57
@obrusvit obrusvit force-pushed the ui-eckhart branch 4 times, most recently from e268b8d to a6bcdd4 Compare May 21, 2025 12:57
@obrusvit obrusvit force-pushed the ui-eckhart branch 12 times, most recently from 0dae3fb to 4dc20e5 Compare May 30, 2025 14:12
@obrusvit obrusvit force-pushed the ui-eckhart branch 2 times, most recently from 98f680e to 75495b4 Compare May 30, 2025 14:44
Base automatically changed from ui-eckhart to main May 30, 2025 15:38
@mmilata mmilata force-pushed the ble branch 3 times, most recently from e26d896 to 699f5bf Compare June 2, 2025 20:28
@mmilata mmilata changed the title BLE branch BLE: pairing flow & fixes Jun 2, 2025
@mmilata mmilata marked this pull request as ready for review June 2, 2025 20:46
@mmilata mmilata requested review from matejcik and prusnak as code owners June 2, 2025 20:46
@mmilata mmilata requested review from ibz and obrusvit and removed request for matejcik and prusnak June 2, 2025 20:46
obrusvit
obrusvit reviewed Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few points to discuss.

Comment thread core/embed/rust/src/ui/component/ble.rs Outdated
Comment thread core/embed/rust/src/ui/layout_eckhart/firmware/action_bar.rs
Comment thread core/src/trezor/wire/context.py Outdated
obrusvit
obrusvit approved these changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mmilata mmilata merged commit 26d6625 into main Jun 5, 2025
106 checks passed
@mmilata mmilata deleted the ble branch June 5, 2025 13:53
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Jun 5, 2025
@bosomt bosomt added the T3W1 Trezor Safe 7 label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obrusvit obrusvit obrusvit approved these changes

@ibz ibz Awaiting requested review from ibz

Assignees

No one assigned

Labels

T3W1 Trezor Safe 7

Projects

Firmware
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmilata @obrusvit @bosomt @trezor-ci