Add CONFLICTING_DATA_SILO_FILTERS DSR error code - #458
Open
iamtheluckyest wants to merge 2 commits into
Open
Conversation
Bulk DSR submissions that set both dataSiloIds and ignoreDataSiloIds need a stable per-input code so the backend can attribute the rejection by index. Co-authored-by: Cursor <cursoragent@cursor.com>
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/design-tokens
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/type-utils
@transcend-io/utils
@transcend-io/mcp
@transcend-io/mcp-server-admin
@transcend-io/mcp-server-assessment
@transcend-io/mcp-server-base
@transcend-io/mcp-server-consent
@transcend-io/mcp-server-discovery
@transcend-io/mcp-server-docs
@transcend-io/mcp-server-dsr
@transcend-io/mcp-server-inventory
@transcend-io/mcp-server-preferences
@transcend-io/mcp-server-workflows
commit: |
iamtheluckyest
marked this pull request as ready for review
August 21, 2026 12:52
jefgodesky
previously approved these changes
Aug 21, 2026
jefgodesky
left a comment
There was a problem hiding this comment.
- We're going to need a changeset on
@transcend-io/privacy-types, but CI already told you that. - This is connected to WAL-10745. Connected to is right, but we wouldn't want that ticket to close just because this part goes out. Will Linear default to that, or should we explicitly label this as
refsto make sure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DsrErrorCode.ConflictingDataSiloFilters(CONFLICTING_DATA_SILO_FILTERS) and its canonical message builder for bulk DSR inputs that set bothdataSiloIdsandignoreDataSiloIds.Test plan
dsrErrorMessage.test.tsMade with Cursor