Skip to content

remove google services #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cesar-sosa-hol wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove google services #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aefefcf
remove google services
cdavidsp Jul 7, 2026
63ea7c1
keep commented out
kate-kazantseva Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.kotlin.compose)
// Add the Google services Gradle plugin
id("com.google.gms.google-services")
}

android {
Expand Down Expand Up @@ -61,12 +59,8 @@ dependencies {
implementation(libs.androidx.material3)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.lifecycle.runtime.ktx)

testImplementation(libs.junit)
androidTestImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.espresso.core)
// Import the Firebase BoM
implementation(platform("com.google.firebase:firebase-bom:34.9.0"))
// implementation("com.google.android.gms:play-services-ads:23.3.0")
implementation("com.google.firebase:firebase-analytics")
}
1 change: 0 additions & 1 deletion app/src/main/java/io/transcend/samplesdk/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import com.google.android.material.bottomsheet.BottomSheetDialog
import io.transcend.webview.TranscendAPI
import io.transcend.webview.TranscendWebView
import io.transcend.webview.models.TranscendConfig
//import com.google.android.gms.ads.MobileAds

@csmccarthy csmccarthy Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get rid of it in the dependency and build files, but we should keep it in the MainActivity, commented out, to show people how to gate an sdk

@kate-kazantseva kate-kazantseva Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cesar-sosa-hol can you address this one please?

import io.transcend.webview.models.ConsentStatus
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
Expand Down
2 changes: 0 additions & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@
plugins {
alias(libs.plugins.android.application) apply false
alias(libs.plugins.kotlin.android) apply false
// Add the dependency for the Google services Gradle plugin
id("com.google.gms.google-services") version "4.4.4" apply false
}