Skip to content

fix(notifications): Send client_id when syncing read state#196

Draft
nfebe wants to merge 1 commit into
devfrom
fix/notifications-client-id-sync
Draft

fix(notifications): Send client_id when syncing read state#196
nfebe wants to merge 1 commit into
devfrom
fix/notifications-client-id-sync

Conversation

@nfebe
Copy link
Copy Markdown
Contributor

@nfebe nfebe commented May 2, 2026

Mark-as-read calls now forward the local client_id and use the existing POST endpoint, so notifications read offline can be linked to their server-side record on next sync instead of staying orphaned.

Mark-as-read calls now forward the local client_id and use the
existing POST endpoint, so notifications read offline can be linked
to their server-side record on next sync instead of staying orphaned.
@nfebe nfebe requested a review from austin047 May 2, 2026 19:30
@austin047
Copy link
Copy Markdown
Collaborator

austin047 commented May 2, 2026

The thing is, client_id generation will run before mark as read, so if it has to work both the client_id and read_at will have to be optional. The first call will set the client id and then the second will mark it as read when the user opens the notification

Or we rename the endpoint to something else that reflects both of this actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants