Add option to force finding libftdi1 using pkg-config until MSYS2 pac…#670
Closed
cr1901 wants to merge 1 commit into
Closed
Add option to force finding libftdi1 using pkg-config until MSYS2 pac…#670cr1901 wants to merge 1 commit into
cr1901 wants to merge 1 commit into
Conversation
cr1901
commented
May 25, 2026
| endif() | ||
|
|
||
| if (USE_LIBFTDI) | ||
| if (USE_LIBFTDI AND LINK_CMAKE_LIBFTDI1) |
Contributor
Author
There was a problem hiding this comment.
Hmmm, maybe this isn't the proper fix. When configuring with pkg-config, I get:
CMake Error at CMakeLists.txt:832 (math):
math cannot parse the expression: " * 100 + ": syntax error, unexpected
exp_TIMES (2).
But probably better to fix it for pkg-config than to gate it out.
Owner
|
Thanks to point this issue. |
Contributor
Author
|
@trabucayre Your commit works fine. Closing this PR. Maybe in the future, |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kage is patched.
The
LibFTDI1Config.cmakemodule in MSYS2/MINGW-packages hardcodes paths in a way thatNinja(at least) cannot find the dependencylibusbwhen trying to build OFL. The oldpkg-configmethod of finding the dep still works fine, however. So add an option to force the old way until a fix finds its way upstream.(I'm taking a peek at it, but seems more difficult to fix than I thought.)